Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(blockifier): migrate remaining tests to all resource bounds (except execution flavors test) #1342

Conversation

dorimedini-starkware
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware commented Oct 12, 2024

This change is Reviewable

Copy link

codecov bot commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.01%. Comparing base (e3165c4) to head (56ff019).
Report is 165 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1342       +/-   ##
===========================================
+ Coverage   40.10%   69.01%   +28.91%     
===========================================
  Files          26      101       +75     
  Lines        1895    13462    +11567     
  Branches     1895    13462    +11567     
===========================================
+ Hits          760     9291     +8531     
- Misses       1100     3769     +2669     
- Partials       35      402      +367     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dorimedini-starkware dorimedini-starkware force-pushed the 10-12-test_blockifier_parametrize_more_tests_in_transactions_test_by_resource_bounds_types branch from 382a360 to 323d1ca Compare October 13, 2024 08:14
@dorimedini-starkware dorimedini-starkware force-pushed the 10-12-test_blockifier_migrate_remaining_tests_to_all_resource_bounds_except_execution_flavors_test_ branch from 8098654 to c673f89 Compare October 13, 2024 08:14
@dorimedini-starkware dorimedini-starkware force-pushed the 10-12-test_blockifier_parametrize_more_tests_in_transactions_test_by_resource_bounds_types branch from 323d1ca to 3650e6c Compare October 13, 2024 08:17
@dorimedini-starkware dorimedini-starkware force-pushed the 10-12-test_blockifier_migrate_remaining_tests_to_all_resource_bounds_except_execution_flavors_test_ branch from c673f89 to 44ef268 Compare October 13, 2024 08:17
@dorimedini-starkware dorimedini-starkware force-pushed the 10-12-test_blockifier_parametrize_more_tests_in_transactions_test_by_resource_bounds_types branch from 3650e6c to c202aa4 Compare October 13, 2024 08:36
@dorimedini-starkware dorimedini-starkware force-pushed the 10-12-test_blockifier_migrate_remaining_tests_to_all_resource_bounds_except_execution_flavors_test_ branch from 44ef268 to a42f31d Compare October 13, 2024 08:36
@dorimedini-starkware dorimedini-starkware force-pushed the 10-12-test_blockifier_parametrize_more_tests_in_transactions_test_by_resource_bounds_types branch from c202aa4 to 8db1c81 Compare October 13, 2024 09:30
@dorimedini-starkware dorimedini-starkware force-pushed the 10-12-test_blockifier_migrate_remaining_tests_to_all_resource_bounds_except_execution_flavors_test_ branch from a42f31d to 96e24a7 Compare October 13, 2024 09:30
@dorimedini-starkware dorimedini-starkware force-pushed the 10-12-test_blockifier_parametrize_more_tests_in_transactions_test_by_resource_bounds_types branch from 8db1c81 to c6c9387 Compare October 13, 2024 12:39
@dorimedini-starkware dorimedini-starkware force-pushed the 10-12-test_blockifier_migrate_remaining_tests_to_all_resource_bounds_except_execution_flavors_test_ branch from 96e24a7 to 138570a Compare October 13, 2024 12:39
@dorimedini-starkware dorimedini-starkware force-pushed the 10-12-test_blockifier_parametrize_more_tests_in_transactions_test_by_resource_bounds_types branch from c6c9387 to 6d8bd5a Compare October 13, 2024 13:04
@dorimedini-starkware dorimedini-starkware force-pushed the 10-12-test_blockifier_migrate_remaining_tests_to_all_resource_bounds_except_execution_flavors_test_ branch from 138570a to 3a5c24b Compare October 13, 2024 13:04
@dorimedini-starkware dorimedini-starkware force-pushed the 10-12-test_blockifier_parametrize_more_tests_in_transactions_test_by_resource_bounds_types branch from 6d8bd5a to e9cf412 Compare October 14, 2024 08:07
@dorimedini-starkware dorimedini-starkware force-pushed the 10-12-test_blockifier_migrate_remaining_tests_to_all_resource_bounds_except_execution_flavors_test_ branch from 3a5c24b to c4021b1 Compare October 14, 2024 08:07
@dorimedini-starkware dorimedini-starkware force-pushed the 10-12-test_blockifier_parametrize_more_tests_in_transactions_test_by_resource_bounds_types branch from 7080ab3 to b771e39 Compare October 31, 2024 13:32
@dorimedini-starkware dorimedini-starkware force-pushed the 10-12-test_blockifier_migrate_remaining_tests_to_all_resource_bounds_except_execution_flavors_test_ branch from 14007bd to 554d8c7 Compare October 31, 2024 13:32
Copy link

Artifacts upload triggered. View details here

@dorimedini-starkware dorimedini-starkware force-pushed the 10-12-test_blockifier_parametrize_more_tests_in_transactions_test_by_resource_bounds_types branch from b771e39 to 8a5f418 Compare October 31, 2024 17:33
@dorimedini-starkware dorimedini-starkware force-pushed the 10-12-test_blockifier_migrate_remaining_tests_to_all_resource_bounds_except_execution_flavors_test_ branch from 554d8c7 to 2d2b0a6 Compare October 31, 2024 17:33
Copy link

Artifacts upload triggered. View details here

@dorimedini-starkware dorimedini-starkware force-pushed the 10-12-test_blockifier_parametrize_more_tests_in_transactions_test_by_resource_bounds_types branch from 8a5f418 to 11153e1 Compare October 31, 2024 17:35
@dorimedini-starkware dorimedini-starkware force-pushed the 10-12-test_blockifier_migrate_remaining_tests_to_all_resource_bounds_except_execution_flavors_test_ branch from 2d2b0a6 to dbd309a Compare October 31, 2024 17:35
Copy link

Artifacts upload triggered. View details here

@dorimedini-starkware dorimedini-starkware force-pushed the 10-12-test_blockifier_parametrize_more_tests_in_transactions_test_by_resource_bounds_types branch from 11153e1 to 4eff252 Compare November 3, 2024 10:02
@dorimedini-starkware dorimedini-starkware force-pushed the 10-12-test_blockifier_migrate_remaining_tests_to_all_resource_bounds_except_execution_flavors_test_ branch from dbd309a to fbf30a6 Compare November 3, 2024 10:02
Copy link

github-actions bot commented Nov 3, 2024

Artifacts upload triggered. View details here

Copy link
Contributor

@yoavGrs yoavGrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

@dorimedini-starkware dorimedini-starkware force-pushed the 10-12-test_blockifier_parametrize_more_tests_in_transactions_test_by_resource_bounds_types branch 2 times, most recently from 121a08f to 1234641 Compare November 3, 2024 11:23
@dorimedini-starkware dorimedini-starkware force-pushed the 10-12-test_blockifier_migrate_remaining_tests_to_all_resource_bounds_except_execution_flavors_test_ branch from fbf30a6 to cb4e4e4 Compare November 3, 2024 11:23
Copy link

github-actions bot commented Nov 3, 2024

Artifacts upload triggered. View details here

@dorimedini-starkware dorimedini-starkware changed the base branch from 10-12-test_blockifier_parametrize_more_tests_in_transactions_test_by_resource_bounds_types to graphite-base/1342 November 3, 2024 14:09
Copy link

github-actions bot commented Nov 3, 2024

Artifacts upload triggered. View details here

@dorimedini-starkware dorimedini-starkware force-pushed the 10-12-test_blockifier_migrate_remaining_tests_to_all_resource_bounds_except_execution_flavors_test_ branch from cb4e4e4 to 04ed1fe Compare November 3, 2024 14:10
Copy link

github-actions bot commented Nov 3, 2024

Artifacts upload triggered. View details here

Copy link

github-actions bot commented Nov 3, 2024

Artifacts upload triggered. View details here

@dorimedini-starkware dorimedini-starkware changed the base branch from graphite-base/1342 to main November 3, 2024 14:11
@dorimedini-starkware dorimedini-starkware force-pushed the 10-12-test_blockifier_migrate_remaining_tests_to_all_resource_bounds_except_execution_flavors_test_ branch from 04ed1fe to 56ff019 Compare November 3, 2024 14:11
Copy link

github-actions bot commented Nov 3, 2024

Artifacts upload triggered. View details here

Copy link

github-actions bot commented Nov 3, 2024

Artifacts upload triggered. View details here

Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

@dorimedini-starkware dorimedini-starkware merged commit 904dd24 into main Nov 3, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants