Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(blockifier): l1 bounds -> all bounds in worker logic test #1309

Conversation

dorimedini-starkware
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware commented Oct 10, 2024

This change is Reviewable

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.45%. Comparing base (b0cfe82) to head (ecba0ee).
Report is 397 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (b0cfe82) and HEAD (ecba0ee). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (b0cfe82) HEAD (ecba0ee)
3 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1309       +/-   ##
===========================================
- Coverage   74.18%   56.45%   -17.73%     
===========================================
  Files         359      316       -43     
  Lines       36240    35530      -710     
  Branches    36240    35530      -710     
===========================================
- Hits        26886    20060     -6826     
- Misses       7220    13876     +6656     
+ Partials     2134     1594      -540     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_l1_bounds_-_all_bounds_in_versioned_state_test branch from 6c693dd to 50c5c89 Compare October 10, 2024 15:11
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_l1_bounds_-_all_bounds_in_worker_logic_test branch from d46f6df to 646017a Compare October 10, 2024 15:11
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_l1_bounds_-_all_bounds_in_versioned_state_test branch from 50c5c89 to 5e19234 Compare October 13, 2024 08:13
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_l1_bounds_-_all_bounds_in_worker_logic_test branch from 646017a to 09cc7c4 Compare October 13, 2024 08:13
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_l1_bounds_-_all_bounds_in_versioned_state_test branch from 5e19234 to c4458ec Compare October 13, 2024 08:16
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_l1_bounds_-_all_bounds_in_worker_logic_test branch from 09cc7c4 to b9a2294 Compare October 13, 2024 08:16
@dorimedini-starkware dorimedini-starkware self-assigned this Oct 13, 2024
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_l1_bounds_-_all_bounds_in_versioned_state_test branch from c4458ec to 9610494 Compare October 13, 2024 12:38
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_l1_bounds_-_all_bounds_in_worker_logic_test branch from b9a2294 to 8e394a1 Compare October 13, 2024 12:38
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_l1_bounds_-_all_bounds_in_versioned_state_test branch from 9610494 to e458074 Compare October 14, 2024 08:06
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_l1_bounds_-_all_bounds_in_worker_logic_test branch from 8e394a1 to cd59355 Compare October 14, 2024 08:06
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_l1_bounds_-_all_bounds_in_versioned_state_test branch from e458074 to 5e46120 Compare October 14, 2024 09:14
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_l1_bounds_-_all_bounds_in_worker_logic_test branch from cd59355 to 9872c20 Compare October 14, 2024 09:14
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_l1_bounds_-_all_bounds_in_versioned_state_test branch from 5e46120 to e7581c7 Compare October 14, 2024 12:12
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_l1_bounds_-_all_bounds_in_worker_logic_test branch from 9872c20 to 81f7485 Compare October 14, 2024 12:12
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_l1_bounds_-_all_bounds_in_versioned_state_test branch from e7581c7 to 343b9d0 Compare October 14, 2024 13:08
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_l1_bounds_-_all_bounds_in_worker_logic_test branch from 81f7485 to 98473e0 Compare October 14, 2024 13:08
Copy link
Contributor

@yoavGrs yoavGrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_l1_bounds_-_all_bounds_in_versioned_state_test branch from 343b9d0 to 750d497 Compare October 15, 2024 07:52
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_l1_bounds_-_all_bounds_in_worker_logic_test branch from 98473e0 to 9e63e8a Compare October 15, 2024 07:52
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_l1_bounds_-_all_bounds_in_versioned_state_test branch from 750d497 to dca6687 Compare October 15, 2024 08:33
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_l1_bounds_-_all_bounds_in_worker_logic_test branch from 9e63e8a to a9b6381 Compare October 15, 2024 08:33
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_l1_bounds_-_all_bounds_in_versioned_state_test branch 2 times, most recently from 64067d2 to aeb522a Compare October 15, 2024 08:59
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_l1_bounds_-_all_bounds_in_worker_logic_test branch from a9b6381 to 8036e2c Compare October 15, 2024 08:59
@dorimedini-starkware dorimedini-starkware changed the base branch from 10-10-test_blockifier_l1_bounds_-_all_bounds_in_versioned_state_test to graphite-base/1309 October 15, 2024 11:30
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_l1_bounds_-_all_bounds_in_worker_logic_test branch from 8036e2c to e05400f Compare October 15, 2024 11:31
@dorimedini-starkware dorimedini-starkware changed the base branch from graphite-base/1309 to main October 15, 2024 11:31
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_l1_bounds_-_all_bounds_in_worker_logic_test branch from e05400f to ecba0ee Compare October 15, 2024 11:31
Copy link
Collaborator Author

dorimedini-starkware commented Oct 15, 2024

Merge activity

  • Oct 15, 8:10 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 15, 8:10 AM EDT: A user merged this pull request with Graphite.

@dorimedini-starkware dorimedini-starkware merged commit 112f7a2 into main Oct 15, 2024
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants