Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(blockifier): add all resource bounds to stateful validator test #1307

Conversation

dorimedini-starkware
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware commented Oct 10, 2024

This change is Reviewable

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.87%. Comparing base (b0cfe82) to head (f69343d).
Report is 385 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (b0cfe82) and HEAD (f69343d). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (b0cfe82) HEAD (f69343d)
3 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1307       +/-   ##
===========================================
- Coverage   74.18%   56.87%   -17.32%     
===========================================
  Files         359      316       -43     
  Lines       36240    35312      -928     
  Branches    36240    35312      -928     
===========================================
- Hits        26886    20084     -6802     
- Misses       7220    13637     +6417     
+ Partials     2134     1591      -543     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-refactor_blockifier_refactor_default_testing_resource_bounds branch from 5182295 to 3098d59 Compare October 10, 2024 15:10
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_add_all_resource_bounds_to_stateful_validator_test branch from 43f4163 to 541e3ca Compare October 10, 2024 15:11
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-refactor_blockifier_refactor_default_testing_resource_bounds branch from 3098d59 to 9d5d04e Compare October 13, 2024 08:13
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_add_all_resource_bounds_to_stateful_validator_test branch from 541e3ca to ae3e6b3 Compare October 13, 2024 08:13
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-refactor_blockifier_refactor_default_testing_resource_bounds branch from 9d5d04e to b7510f2 Compare October 13, 2024 08:15
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_add_all_resource_bounds_to_stateful_validator_test branch from ae3e6b3 to 23e75f6 Compare October 13, 2024 08:15
@dorimedini-starkware dorimedini-starkware self-assigned this Oct 13, 2024
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-refactor_blockifier_refactor_default_testing_resource_bounds branch from b7510f2 to 0e5387e Compare October 13, 2024 12:38
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_add_all_resource_bounds_to_stateful_validator_test branch from 23e75f6 to 920351b Compare October 13, 2024 12:38
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-refactor_blockifier_refactor_default_testing_resource_bounds branch from 0e5387e to 70c77e5 Compare October 14, 2024 08:06
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_add_all_resource_bounds_to_stateful_validator_test branch from 920351b to ce63edc Compare October 14, 2024 08:06
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-refactor_blockifier_refactor_default_testing_resource_bounds branch from 70c77e5 to 404d032 Compare October 14, 2024 09:14
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_add_all_resource_bounds_to_stateful_validator_test branch from ce63edc to af2eed1 Compare October 14, 2024 09:14
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-refactor_blockifier_refactor_default_testing_resource_bounds branch from 404d032 to 42b94c9 Compare October 14, 2024 12:12
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_add_all_resource_bounds_to_stateful_validator_test branch from af2eed1 to 556c943 Compare October 14, 2024 12:12
Copy link
Contributor

@yoavGrs yoavGrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-refactor_blockifier_refactor_default_testing_resource_bounds branch from 42b94c9 to 068214d Compare October 15, 2024 07:52
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_add_all_resource_bounds_to_stateful_validator_test branch from 556c943 to 6e4825a Compare October 15, 2024 07:52
@dorimedini-starkware dorimedini-starkware changed the base branch from 10-10-refactor_blockifier_refactor_default_testing_resource_bounds to graphite-base/1307 October 15, 2024 08:32
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_add_all_resource_bounds_to_stateful_validator_test branch from 6e4825a to 1de9c83 Compare October 15, 2024 08:32
@dorimedini-starkware dorimedini-starkware changed the base branch from graphite-base/1307 to main October 15, 2024 08:33
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_add_all_resource_bounds_to_stateful_validator_test branch from 1de9c83 to f69343d Compare October 15, 2024 08:33
@dorimedini-starkware dorimedini-starkware merged commit c66d3c2 into main Oct 15, 2024
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants