test(blockifier): test enforce_fee flag with new resource bounds

[dorimedini-starkware]

This change is 

[dorimedini-starkware]

• test(blockifier): migrate remaining tests to all resource bounds (except execution flavors test) #1342
• test(blockifier): parametrize more tests in transactions_test by resource bounds types #1337
• test(blockifier): parametrize test_actual_fee_gt_resource_bounds by resource bounds types #1330
• test(blockifier): parametrize test_max_fee_exceeds_balance by resource bounds types #1322
• test(blockifier): parametrize test_invoke_tx by resource bounds types #1321
• test(blockifier): update test_revert_on_resource_overuse to include new resource bounds #1314
• test(blockifier): update test_insufficient_max_fee_reverts to include new resource bounds #1313
• test(blockifier): l1 bounds -> all bounds (or parametrize) in account transaction test #1312
• test(blockifier): test enforce_fee flag with new resource bounds #1311 👈
• test(blockifier): l1 bounds -> all bounds in stack trace test #1310
• test(blockifier): l1 bounds -> all bounds in worker logic test #1309
• test(blockifier): l1 bounds -> all bounds in versioned state test #1308
• test(blockifier): add all resource bounds to stateful validator test #1307
• refactor(blockifier): refactor default testing resource bounds #1306
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dorimedini-starkware and the rest of your teammates on Graphite

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.12%. Comparing base (e3165c4) to head (f76c2ef).
Report is 59 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #1311       +/-   ##
===========================================
+ Coverage   40.10%   69.12%   +29.02%     
===========================================
  Files          26      100       +74     
  Lines        1895    13446    +11551     
  Branches     1895    13446    +11551     
===========================================
+ Hits          760     9295     +8535     
- Misses       1100     3750     +2650     
- Partials       35      401      +366     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[yoavGrs]

Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @dorimedini-starkware)

---

crates/blockifier/src/transaction/account_transactions_test.rs line 187 at r1 (raw file):

        deploy_account_tx_args! {
            class_hash: account.get_class_hash(),
            max_fee: Fee(u128::from(bound_multiplier) * MAX_FEE.0),

I prefer to write it explicitly.
(If you accept it, remove thebound_multiplier)

Suggestion:

max_fee: Fee(if zero_bounds { 0 } else { MAX_FEE.0 }),

---

crates/blockifier/src/transaction/account_transactions_test.rs line 208 at r1 (raw file):

    let account_tx = AccountTransaction::DeployAccount(deploy_account_tx);
    let enforce_fee = account_tx.create_tx_info().enforce_fee();

Please verify that
assert_ne!(zero_bounds, enforce_fee);

---

crates/blockifier/src/transaction/account_transactions_test.rs line 210 at r1 (raw file):

    let enforce_fee = account_tx.create_tx_info().enforce_fee();
    let result = account_tx.execute(state, &block_context, enforce_fee, true);
    assert_eq!(result.is_err(), enforce_fee);

Explain in a comment, why the tx fails where there are gas bounds.

[dorimedini-starkware]

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @yoavGrs)

---

crates/blockifier/src/transaction/account_transactions_test.rs line 208 at r1 (raw file):

Previously, yoavGrs wrote…

Please verify that
assert_ne!(zero_bounds, enforce_fee);

Done.

---

crates/blockifier/src/transaction/account_transactions_test.rs line 210 at r1 (raw file):

Previously, yoavGrs wrote…

Explain in a comment, why the tx fails where there are gas bounds.

Done.

[github-actions]

Artifacts upload triggered. View details here

[yoavGrs]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

[dorimedini-starkware]

Merge activity

• Oct 29, 6:40 AM EDT: A user started a stack merge that includes this pull request via Graphite.
• Oct 29, 6:41 AM EDT: A user merged this pull request with Graphite.