Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(blockifier): l1 bounds -> all bounds (or parametrize) in account transaction test #1312

Conversation

dorimedini-starkware
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware commented Oct 10, 2024

This change is Reviewable

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.13%. Comparing base (e3165c4) to head (91c0e0c).
Report is 60 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1312       +/-   ##
===========================================
+ Coverage   40.10%   69.13%   +29.03%     
===========================================
  Files          26      100       +74     
  Lines        1895    13446    +11551     
  Branches     1895    13446    +11551     
===========================================
+ Hits          760     9296     +8536     
- Misses       1100     3750     +2650     
- Partials       35      400      +365     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_test_enforce_fee_flag_with_new_resource_bounds branch from 63f505b to b1eb61d Compare October 10, 2024 15:11
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_l1_bounds_-_all_bounds_or_parametrize_in_account_transaction_test branch from b04682d to eb8ef23 Compare October 10, 2024 15:11
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_test_enforce_fee_flag_with_new_resource_bounds branch from b1eb61d to ad71ad0 Compare October 13, 2024 08:13
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_l1_bounds_-_all_bounds_or_parametrize_in_account_transaction_test branch from eb8ef23 to 0173dfa Compare October 13, 2024 08:13
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_test_enforce_fee_flag_with_new_resource_bounds branch from ad71ad0 to 94b0ea2 Compare October 13, 2024 08:16
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_l1_bounds_-_all_bounds_or_parametrize_in_account_transaction_test branch from 0173dfa to 43ad094 Compare October 13, 2024 08:16
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_test_enforce_fee_flag_with_new_resource_bounds branch from 94b0ea2 to 826231f Compare October 13, 2024 12:38
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_l1_bounds_-_all_bounds_or_parametrize_in_account_transaction_test branch from 43ad094 to 1e7005b Compare October 13, 2024 12:38
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_test_enforce_fee_flag_with_new_resource_bounds branch from 826231f to 24b7c7a Compare October 13, 2024 13:04
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_l1_bounds_-_all_bounds_or_parametrize_in_account_transaction_test branch from 1e7005b to eacda12 Compare October 13, 2024 13:04
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_test_enforce_fee_flag_with_new_resource_bounds branch from 24b7c7a to fd1a2e9 Compare October 14, 2024 08:06
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_l1_bounds_-_all_bounds_or_parametrize_in_account_transaction_test branch from eacda12 to fd85e54 Compare October 14, 2024 08:06
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_test_enforce_fee_flag_with_new_resource_bounds branch from fd1a2e9 to 701e17e Compare October 14, 2024 09:14
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_l1_bounds_-_all_bounds_or_parametrize_in_account_transaction_test branch from fd85e54 to 907f84e Compare October 14, 2024 09:14
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_test_enforce_fee_flag_with_new_resource_bounds branch from 6d46d6a to dd72a30 Compare October 15, 2024 08:34
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_l1_bounds_-_all_bounds_or_parametrize_in_account_transaction_test branch from 3cd23de to d3162cc Compare October 15, 2024 08:35
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_test_enforce_fee_flag_with_new_resource_bounds branch from dd72a30 to ed36be2 Compare October 15, 2024 09:00
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_l1_bounds_-_all_bounds_or_parametrize_in_account_transaction_test branch from d3162cc to 39f692e Compare October 15, 2024 09:01
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_test_enforce_fee_flag_with_new_resource_bounds branch from ed36be2 to 20e99f2 Compare October 15, 2024 11:32
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_l1_bounds_-_all_bounds_or_parametrize_in_account_transaction_test branch from 39f692e to d2f03da Compare October 15, 2024 11:32
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_test_enforce_fee_flag_with_new_resource_bounds branch from 20e99f2 to e5f3853 Compare October 15, 2024 12:36
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_l1_bounds_-_all_bounds_or_parametrize_in_account_transaction_test branch from d2f03da to c3dbc09 Compare October 15, 2024 12:37
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_test_enforce_fee_flag_with_new_resource_bounds branch from e5f3853 to 37e762f Compare October 15, 2024 15:56
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_l1_bounds_-_all_bounds_or_parametrize_in_account_transaction_test branch from c3dbc09 to d14a88e Compare October 15, 2024 15:56
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_test_enforce_fee_flag_with_new_resource_bounds branch from 37e762f to 625b6a3 Compare October 22, 2024 11:53
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_l1_bounds_-_all_bounds_or_parametrize_in_account_transaction_test branch from d14a88e to 25ac8f0 Compare October 22, 2024 11:53
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_test_enforce_fee_flag_with_new_resource_bounds branch from 625b6a3 to a3a6d78 Compare October 22, 2024 11:56
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_l1_bounds_-_all_bounds_or_parametrize_in_account_transaction_test branch from 25ac8f0 to f056a9d Compare October 22, 2024 11:57
Copy link
Contributor

@yoavGrs yoavGrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)


crates/blockifier/src/transaction/account_transactions_test.rs line 372 at r1 (raw file):

    #[values(true, false)] normal_recurse: bool,
    mut block_context: BlockContext,
    #[values(default_l1_resource_bounds(), default_all_resource_bounds())]

Why both?

Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @yoavGrs)


crates/blockifier/src/transaction/account_transactions_test.rs line 372 at r1 (raw file):

Previously, yoavGrs wrote…

Why both?

so we know runs are limited by resources in both cases

@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_test_enforce_fee_flag_with_new_resource_bounds branch from a3a6d78 to f76c2ef Compare October 28, 2024 14:47
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_l1_bounds_-_all_bounds_or_parametrize_in_account_transaction_test branch from f056a9d to fbbc727 Compare October 28, 2024 14:48
Copy link

Artifacts upload triggered. View details here

Copy link
Contributor

@yoavGrs yoavGrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

Copy link
Collaborator Author

dorimedini-starkware commented Oct 29, 2024

Merge activity

  • Oct 29, 6:40 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 29, 6:43 AM EDT: Graphite rebased this pull request as part of a merge.
  • Oct 29, 6:53 AM EDT: A user merged this pull request with Graphite.

@dorimedini-starkware dorimedini-starkware changed the base branch from 10-10-test_blockifier_test_enforce_fee_flag_with_new_resource_bounds to graphite-base/1312 October 29, 2024 10:41
@dorimedini-starkware dorimedini-starkware changed the base branch from graphite-base/1312 to main October 29, 2024 10:41
Copy link

Artifacts upload triggered. View details here

@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-test_blockifier_l1_bounds_-_all_bounds_or_parametrize_in_account_transaction_test branch from fbbc727 to 91c0e0c Compare October 29, 2024 10:42
Copy link

Artifacts upload triggered. View details here

Copy link

Artifacts upload triggered. View details here

@dorimedini-starkware dorimedini-starkware merged commit 27784b2 into main Oct 29, 2024
12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants