-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(blockifier): l1 bounds -> all bounds (or parametrize) in account transaction test #1312
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1312 +/- ##
===========================================
+ Coverage 40.10% 69.13% +29.03%
===========================================
Files 26 100 +74
Lines 1895 13446 +11551
Branches 1895 13446 +11551
===========================================
+ Hits 760 9296 +8536
- Misses 1100 3750 +2650
- Partials 35 400 +365 ☔ View full report in Codecov by Sentry. |
63f505b
to
b1eb61d
Compare
b04682d
to
eb8ef23
Compare
b1eb61d
to
ad71ad0
Compare
eb8ef23
to
0173dfa
Compare
ad71ad0
to
94b0ea2
Compare
0173dfa
to
43ad094
Compare
94b0ea2
to
826231f
Compare
43ad094
to
1e7005b
Compare
826231f
to
24b7c7a
Compare
1e7005b
to
eacda12
Compare
24b7c7a
to
fd1a2e9
Compare
eacda12
to
fd85e54
Compare
fd1a2e9
to
701e17e
Compare
fd85e54
to
907f84e
Compare
6d46d6a
to
dd72a30
Compare
3cd23de
to
d3162cc
Compare
dd72a30
to
ed36be2
Compare
d3162cc
to
39f692e
Compare
ed36be2
to
20e99f2
Compare
39f692e
to
d2f03da
Compare
20e99f2
to
e5f3853
Compare
d2f03da
to
c3dbc09
Compare
e5f3853
to
37e762f
Compare
c3dbc09
to
d14a88e
Compare
37e762f
to
625b6a3
Compare
d14a88e
to
25ac8f0
Compare
625b6a3
to
a3a6d78
Compare
25ac8f0
to
f056a9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)
crates/blockifier/src/transaction/account_transactions_test.rs
line 372 at r1 (raw file):
#[values(true, false)] normal_recurse: bool, mut block_context: BlockContext, #[values(default_l1_resource_bounds(), default_all_resource_bounds())]
Why both?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @yoavGrs)
crates/blockifier/src/transaction/account_transactions_test.rs
line 372 at r1 (raw file):
Previously, yoavGrs wrote…
Why both?
so we know runs are limited by resources in both cases
a3a6d78
to
f76c2ef
Compare
f056a9d
to
fbbc727
Compare
Artifacts upload triggered. View details here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)
… transaction test
Artifacts upload triggered. View details here |
fbbc727
to
91c0e0c
Compare
Artifacts upload triggered. View details here |
Artifacts upload triggered. View details here |
This change is