You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 26, 2019. It is now read-only.
In the current implementation, logic is calling initializeStorage() method which creates the storage file object. For LO-DIP and later LO-OCP we explain the following:
Using DIP and making StorageFile extend Storage helps OCP as well, because, we can pass any object that is Storage and logic should pick it up.
As long as initializeStorage() is creating the correct type of storage object inside Logic, logic is not closed for modification.
I suggest we move creating the storage object to MainWindow and call Logic::setStorage from there to set the underlying storage.
The text was updated successfully, but these errors were encountered:
In the current implementation, logic is calling
initializeStorage()
method which creates the storage file object. For LO-DIP and later LO-OCP we explain the following:Using DIP and making
StorageFile
extendStorage
helps OCP as well, because, we can pass any object that is Storage and logic should pick it up.As long as
initializeStorage()
is creating the correct type of storage object insideLogic
, logic is not closed for modification.I suggest we move creating the storage object to
MainWindow
and callLogic::setStorage
from there to set the underlying storage.The text was updated successfully, but these errors were encountered: