[T6A1][W10-B3]Wang Chi #435
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modify StorageFile class to extend Storage class - Modify Logic to use Storage class - Modify Gui to update changed method name
hwkchia
reviewed
Mar 7, 2017
| */ | ||
| private StorageFile initializeStorage() throws StorageFile.InvalidStorageFilePathException { | ||
| private Storage initializeStorage() throws StorageFile.InvalidStorageFilePathException { | ||
| return new StorageFile(); |
There was a problem hiding this comment.
👍 Good job attempting DIP.
The creating of StorageFile is a little unfortunate, but nonetheless has to be done. The original design already violates OCP. Fyi, an issue has been raised regarding this se-edu/addressbook-level3#75
| public abstract static class InvalidStoragePathException extends IllegalValueException { | ||
| public InvalidStoragePathException(String message) { | ||
| super(message); | ||
| } |
There was a problem hiding this comment.
👍 but need not be abstract... can include the other exception handler also...
| @@ -15,7 +15,7 @@ | |||
| /** | |||
| * Represents the file used to store address book data. | |||
| */ | |||
| public class StorageFile { | |||
| public class StorageFile extends Storage{ | |||
There was a problem hiding this comment.
Can consider letting Storage deal with exception handling
|
Ack by closing PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.