[T6A1][W10-B4]Li Chengcheng #527
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwkchia
reviewed
Mar 7, 2017
There was a problem hiding this comment.
Good attempt.
As we are now using StorageStub in LogicTest, we need not test the correctness of StorageFile when we test the Logic class. There is a line in the assertCommandBehavior method that checks for the contents on the disk with the contents in memory; this should be removed.
| @@ -17,7 +18,7 @@ | |||
| public class Logic { | |||
|
|
|||
|
|
|||
| private StorageFile storage; | |||
| private Storage storage; | |||
| private StorageFile initializeStorage() throws StorageFile.InvalidStorageFilePathException { | ||
| return new StorageFile(); | ||
| private Storage initializeStorage() throws StorageFile.InvalidStorageFilePathException { | ||
| return new StorageFile();//I'm not sure how to get rid of this coupling |
There was a problem hiding this comment.
Yes, this part is unfortunate, but it's the best we can do right now. The original design already violates OCP. Fyi, an issue has been raised regarding this se-edu/addressbook-level3#75
| public abstract AddressBook load() throws StorageOperationException; | ||
| public abstract void save(AddressBook addressBook) throws StorageOperationException; | ||
| public abstract String getPath(); | ||
| } |
| import seedu.addressbook.data.AddressBook; | ||
| import seedu.addressbook.storage.StorageFile.StorageOperationException; | ||
|
|
||
| public class StorageStub extends Storage { |
| return path; | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
👍 better to put StorageStub in the test directory though...
|
|
||
| @Override | ||
| public AddressBook load() throws StorageOperationException { | ||
| return null; |
|
Ack by closing PR |
1 similar comment
|
Ack by closing PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.