[T6A1][W10-B3] Chen Penghao #358
Conversation
There was a problem hiding this comment.
As we are now using StorageStub in LogicTest, we need not test the correctness of StorageFile when we test the Logic class. There is a line in the assertCommandBehavior method that checks for the contents on the disk with the contents in memory; this should be removed.
| @@ -45,7 +46,7 @@ void setAddressBook(AddressBook addressBook){ | |||
| * Creates the StorageFile object based on the user specified path (if any) or the default storage path. | |||
| * @throws StorageFile.InvalidStorageFilePathException if the target file path is incorrect. | |||
| */ | |||
| private StorageFile initializeStorage() throws StorageFile.InvalidStorageFilePathException { | |||
| private Storage initializeStorage() throws Storage.InvalidStoragePathException { | |||
| return new StorageFile(); | |||
| } | |||
There was a problem hiding this comment.
👍 applying DIP.
The creating of StorageFile is a little unfortunate, but nonetheless has to be done. The original design already violates OCP. Fyi, an issue has been raised regarding this se-edu/addressbook-level3#75
| import seedu.addressbook.data.exception.IllegalValueException; | ||
| import seedu.addressbook.storage.Storage.StorageOperationException; | ||
|
|
||
| public abstract class Storage { |
| public InvalidStoragePathException(String message) { | ||
| super(message); | ||
| } | ||
| } |
| } | ||
| } | ||
|
|
||
| public abstract AddressBook load() throws StorageOperationException; |
| @Override | ||
| public AddressBook load() throws StorageOperationException { | ||
| // TODO Auto-generated method stub | ||
| return null; |
| import seedu.addressbook.storage.Storage.InvalidStoragePathException; | ||
| import seedu.addressbook.storage.jaxb.AdaptedAddressBook; | ||
|
|
||
| public class StorageStub extends Storage { |
There was a problem hiding this comment.
StorageStub should be as minimal as possible since it's just there to support testing other functionalities.
You should also place StorageStub in the test directory rather than src
|
Ack by closing PR |
No description provided.