[T6A1][W10-B4]Goh Yue Quan #432
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwkchia
reviewed
Mar 7, 2017
| @@ -45,11 +47,11 @@ void setAddressBook(AddressBook addressBook){ | |||
| * Creates the StorageFile object based on the user specified path (if any) or the default storage path. | |||
| * @throws StorageFile.InvalidStorageFilePathException if the target file path is incorrect. | |||
| */ | |||
| private StorageFile initializeStorage() throws StorageFile.InvalidStorageFilePathException { | |||
| private Storage initializeStorage() throws InvalidStoragePathException { | |||
| return new StorageFile(); | |||
There was a problem hiding this comment.
👍 Good attempt at applying DIP.
The creating of StorageFile is a little unfortunate, but nonetheless has to be done. The original design already violates OCP. Fyi, an issue has been raised regarding this se-edu/addressbook-level3#75
| public StorageOperationException(String message) { | ||
| super(message); | ||
| } | ||
| } |
| } | ||
| } | ||
|
|
||
| public abstract void save(AddressBook addressBook) throws StorageOperationException; |
| @@ -90,7 +89,7 @@ private void assertCommandBehavior(String inputCommand, | |||
| //Confirm the state of data is as expected | |||
| assertEquals(expectedAddressBook, addressBook); | |||
| assertEquals(lastShownList, logic.getLastShownList()); | |||
| assertEquals(addressBook, saveFile.load()); | |||
| assertEquals(null, storageStub.load()); | |||
There was a problem hiding this comment.
👍 You are the only one to have identified this. You can simply just remove the line 😄
|
|
||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
👍 Very nice. Minimalist and in the correct directory. ⭐️
|
Ack by closing PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added abstract class storage