Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AARD-1687: Save exporter options with active design #981

Merged
merged 85 commits into from
Jun 25, 2024

Conversation

BrandonPacewic
Copy link
Member

@BrandonPacewic BrandonPacewic commented Jun 19, 2024

My overall conclusion? The exporter needs to be rewritten...

Description

Small refactor to the parser options configurable from the settings panel. Now will save settings upon a robot export to the individual robot design.

Objectives

  • Generalized exporter options class
  • Ability to save / load general options class
  • Refactor parser and config panel for new options class
  • Refactor parser and config panel to rely on enums

Note

Joint and specific wheel options are still not loaded properly (they do currently save), this will be a part of AARD-1685

Note

I also removed several of the exporter options that were not being used and that their removal did not immediately break anything.
These options will likely be re-implemented and add back in the future.

JIRA Issue

@BrandonPacewic BrandonPacewic marked this pull request as ready for review June 20, 2024 20:49
@BrandonPacewic BrandonPacewic requested a review from a team as a code owner June 20, 2024 20:49
@BrandonPacewic
Copy link
Member Author

BrandonPacewic commented Jun 21, 2024

Well the problem was not with the exporter but with the importer in v6. Tryout the exported robot in barclah/mira-upload for testing.

The robot will be found in ~/.config/Autodesk/Synthesis/Mira/. We will update the exporter to show a panel to choose the export location in #980.

Copy link
Member

@HunterBarclay HunterBarclay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BrandonPacewic Did some digging and it looks like if you selected a location previously, Fusion will override the default folder, which I'm fine with tbh. I added a ternary for the default fileLocation to check if the exporter is on Windows, and if so, get the %HOME% variable. @PepperLola Could you please verify on your end it still works on mac?

@HunterBarclay
Copy link
Member

HunterBarclay commented Jun 22, 2024

@LucaHaverty When you have Fusion installed, follow the /exporter/SynthesisFusionAddin/README.md for setup, and see if you can export Dozer, checking to see if the file dialog initially takes you to the user directory. Please let me know if you need help setting up, as well as your email so I can add you to the Fusion hub.

@HunterBarclay
Copy link
Member

HunterBarclay commented Jun 22, 2024

@BrandonPacewic Are we going to let the Black formatter fail for this PR? I saw you working on it earlier today.

@BrandonPacewic
Copy link
Member Author

@BrandonPacewic Are we going to let the Black formatter fail for this PR? I saw you working on it earlier today.

@HunterBarclay

Yes we can let it fail, updates are ready to go once we get everything merged in from current open PRs.

Copy link
Member

@HunterBarclay HunterBarclay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking and working great on MacOS. @BrandonPacewic Could you pull this down to your work laptop and verify that the windows home folder in the FileDialog works?

@BrandonPacewic
Copy link
Member Author

BrandonPacewic commented Jun 24, 2024

@HunterBarclay

Looking and working great on MacOS. @BrandonPacewic Could you pull this down to your work laptop and verify that the windows home folder in the FileDialog works?

👍 Everything works on both windows and mac for me.

@BrandonPacewic BrandonPacewic changed the title Save exporter options with active design AARD-1687: Save exporter options with active design Jun 24, 2024
@HunterBarclay
Copy link
Member

@BrandonPacewic Pulling it down on my Windows machine rn. Once I get Fusion updated on my Windows machine, I'll test and bypass the 2 review restriction

@HunterBarclay
Copy link
Member

@BrandonPacewic Added fix for Windows deps installation. Clearing issues on security bandit due to a false positive. Still haven't tested the home folder directory due to it navigating to the last used directory. I'm asking in API slack channel to see if there is a work around for testing.

BrandonPacewic and others added 5 commits June 24, 2024 15:50
…desk/synthesis into branp/1687/parsing-options-refactor

* 'branp/1687/parsing-options-refactor' of github.com:Autodesk/synthesis:
  Updated print to show joined command instead of tuple
@HunterBarclay HunterBarclay merged commit 7f9e87c into dev Jun 25, 2024
13 of 14 checks passed
@HunterBarclay HunterBarclay deleted the branp/1687/parsing-options-refactor branch June 25, 2024 02:24
@BrandonPacewic BrandonPacewic mentioned this pull request Jun 26, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants