-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AARD-1687: Save exporter options with active design #981
Conversation
* Slight bug * Fixed
Well the problem was not with the exporter but with the importer in v6. Tryout the exported robot in
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BrandonPacewic Did some digging and it looks like if you selected a location previously, Fusion will override the default folder, which I'm fine with tbh. I added a ternary for the default fileLocation
to check if the exporter is on Windows, and if so, get the %HOME%
variable. @PepperLola Could you please verify on your end it still works on mac?
@LucaHaverty When you have Fusion installed, follow the |
@BrandonPacewic Are we going to let the Black formatter fail for this PR? I saw you working on it earlier today. |
Yes we can let it fail, updates are ready to go once we get everything merged in from current open PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking and working great on MacOS. @BrandonPacewic Could you pull this down to your work laptop and verify that the windows home folder in the FileDialog works?
👍 Everything works on both windows and mac for me. |
@BrandonPacewic Pulling it down on my Windows machine rn. Once I get Fusion updated on my Windows machine, I'll test and bypass the 2 review restriction |
@BrandonPacewic Added fix for Windows deps installation. Clearing issues on security bandit due to a false positive. Still haven't tested the home folder directory due to it navigating to the last used directory. I'm asking in API slack channel to see if there is a work around for testing. |
…desk/synthesis into branp/1687/parsing-options-refactor * 'branp/1687/parsing-options-refactor' of github.com:Autodesk/synthesis: Updated print to show joined command instead of tuple
My overall conclusion? The exporter needs to be rewritten...
Description
Small refactor to the parser options configurable from the settings panel. Now will save settings upon a robot export to the individual robot design.
Objectives
Note
Joint and specific wheel options are still not loaded properly (they do currently save), this will be a part of AARD-1685
Note
I also removed several of the exporter options that were not being used and that their removal did not immediately break anything.
These options will likely be re-implemented and add back in the future.
JIRA Issue