Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Remove configure.py #1046

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Refactor: Remove configure.py #1046

merged 3 commits into from
Jul 25, 2024

Conversation

BrandonPacewic
Copy link
Member

  1. Actual use of this code was removed a long time ago.
  2. Functionality was replaced by AARD-1687: Save exporter options with active design #981.

Made this it's own PR so that it will be easy to find if we ever want to look back at it.

@BrandonPacewic BrandonPacewic added exporter refactor The most important part of software development. labels Jul 24, 2024
@BrandonPacewic BrandonPacewic self-assigned this Jul 24, 2024
@BrandonPacewic BrandonPacewic requested review from PepperLola and azaleacolburn and removed request for a team July 24, 2024 22:12
Copy link
Member

@PepperLola PepperLola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Member

@azaleacolburn azaleacolburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* dev:
  PR suggestions for named inputs
  UI improvements, bug fixes, comments, and cleanup for named inputs
  lint fix and format
  Reset all inputs works and ejector + intake bindings
  Input saving and configuration fixes
  Create new custom input schemes that are assigned a random name
  Save and load named controls
  Input selection of default and custom named schemes
  Panel to pick a control scheme and brain configuration events
@HunterBarclay HunterBarclay merged commit 0b52f29 into dev Jul 25, 2024
13 checks passed
@HunterBarclay HunterBarclay deleted the branp/remove-configure branch July 30, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter refactor The most important part of software development.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants