-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AARD-1710: Exporter auto formatter updates #985
Conversation
@BrandonPacewic I don't know if this is a fusion specific thing or not, but on windows, I ran into issues of using subprocess for starting other processes. Instead, we used |
@HunterBarclay Just ran it on my machine with no problems. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BrandonPacewic When I run format.py
, it doesn't appear to be using the configuration settings in pyproject.toml
. When running the formatter, it is trying to make the following changes to src/Analytics/poster.py
:
@HunterBarclay Does the script give you a warning about not being in the correct directory before it runs? If not, then make sure your version of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
@BrandonPacewic Resolve conflicts, then we can merge |
@BrandonPacewic Nvm, took care of it |
Unfortunately not many options to choose from.
120
for all.py
files.isort
before runningblack
.JIRA Issue