Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AARD-1710: Exporter auto formatter updates #985

Merged
merged 23 commits into from
Jun 27, 2024

Conversation

BrandonPacewic
Copy link
Member

Unfortunately not many options to choose from.

Black is a PEP 8 compliant opinionated formatter. Black reformats entire files in place. Style configuration options are deliberately limited and rarely added.

  • Increased line length to 120 for all .py files.
  • Now sorting imports with isort before running black.

JIRA Issue

@BrandonPacewic
Copy link
Member Author

BrandonPacewic commented Jun 21, 2024

Important

Blocked by #981 and #980.

@BrandonPacewic BrandonPacewic self-assigned this Jun 21, 2024
@BrandonPacewic BrandonPacewic changed the title Exporter auto formatter updates AARD-1710: Exporter auto formatter updates Jun 24, 2024
@BrandonPacewic BrandonPacewic marked this pull request as ready for review June 25, 2024 20:06
@BrandonPacewic BrandonPacewic requested a review from a team as a code owner June 25, 2024 20:06
@BrandonPacewic BrandonPacewic requested review from PepperLola and LucaHaverty and removed request for a team June 25, 2024 20:06
@BrandonPacewic BrandonPacewic added the formatting Changes related to the formatting or auto-formatting of source code files. label Jun 26, 2024
@HunterBarclay
Copy link
Member

@BrandonPacewic I don't know if this is a fusion specific thing or not, but on windows, I ran into issues of using subprocess for starting other processes. Instead, we used os.system() in deps.py

@BrandonPacewic
Copy link
Member Author

@BrandonPacewic I don't know if this is a fusion specific thing or not, but on windows, I ran into issues of using subprocess for starting other processes. Instead, we used os.system() in deps.py

@HunterBarclay Just ran it on my machine with no problems.

Copy link
Member

@HunterBarclay HunterBarclay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BrandonPacewic When I run format.py, it doesn't appear to be using the configuration settings in pyproject.toml. When running the formatter, it is trying to make the following changes to src/Analytics/poster.py:

image

@BrandonPacewic
Copy link
Member Author

BrandonPacewic commented Jun 27, 2024

@BrandonPacewic When I run format.py, it doesn't appear to be using the configuration settings in pyproject.toml. When running the formatter, it is trying to make the following changes to src/Analytics/poster.py:

@HunterBarclay Does the script give you a warning about not being in the correct directory before it runs?

If not, then make sure your version of black is up to date.

@PepperLola PepperLola mentioned this pull request Jun 27, 2024
@BrandonPacewic BrandonPacewic mentioned this pull request Jun 27, 2024
3 tasks
@HunterBarclay HunterBarclay self-requested a review June 27, 2024 18:09
Copy link
Member

@HunterBarclay HunterBarclay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@LucaHaverty LucaHaverty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@HunterBarclay
Copy link
Member

@BrandonPacewic Resolve conflicts, then we can merge

@HunterBarclay
Copy link
Member

@BrandonPacewic Nvm, took care of it

@HunterBarclay HunterBarclay merged commit 55c0206 into dev Jun 27, 2024
11 of 12 checks passed
@HunterBarclay HunterBarclay deleted the branp/1710/exporter-formatting-updates branch June 27, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter formatting Changes related to the formatting or auto-formatting of source code files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants