Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AARD-1685: Joint Config Panel #995

Merged
merged 24 commits into from
Jul 22, 2024
Merged

Conversation

BrandonPacewic
Copy link
Member

@BrandonPacewic BrandonPacewic commented Jun 26, 2024

  • Created a new exporter tab containing all joint configuration options.
  • Integrated wheel options within the joint tab for Revolute joints.
  • Moved all event listeners' 'handle' dealing with updates of the joint panel into a seperate file.
  • Joint settings now correctly load and save from ExporterOptions as implemented in AARD-1687: Save exporter options with active design #981.
  • Added several quality of life things for dealing with the joint panel:
    • Adding a joint that is already added will now prompt for removal of selected joint before actually removing it.
    • Added a cancel button to escape out of joint selection mode.
  • And, of course, small refactors here and there related to these changes as a part of ongoing exporter refactors (AARD-1719).
    • I say small refactors but this one was rather large.

JIRA Issue

@BrandonPacewic BrandonPacewic marked this pull request as ready for review July 1, 2024 22:56
@BrandonPacewic BrandonPacewic requested a review from a team as a code owner July 1, 2024 22:56
@BrandonPacewic BrandonPacewic requested review from HunterBarclay, Dhruv-0-Arora and PepperLola and removed request for a team and Dhruv-0-Arora July 1, 2024 22:56
@HunterBarclay
Copy link
Member

@BrandonPacewic I made all the joints in dozer wheels, and then made the speed for Left1 and Right1 90. Then clicked export.

@HunterBarclay
Copy link
Member

image

@HunterBarclay
Copy link
Member

image

@HunterBarclay
Copy link
Member

Looks like fileLocation is None, but so is joints?

@BrandonPacewic
Copy link
Member Author

@HunterBarclay Blocked on this bug as I cannot recreate it.

BrandonPacewic added a commit that referenced this pull request Jul 11, 2024
Needed panel updates to be consistent. Will need to update this branch
after GH-995 is merged.
@BrandonPacewic BrandonPacewic requested a review from a team as a code owner July 12, 2024 23:05
@BrandonPacewic BrandonPacewic requested review from azaleacolburn and removed request for a team July 12, 2024 23:05
@BrandonPacewic
Copy link
Member Author

The issue was related to @HunterBarclay 's HOME directory not existing somehow. This paired with the ExporterOptions object being reset as you have a version of Dozer that does not have the new isWheel boolean saved within the design caused it to crash. Everything in the chain now can handle receiving a value of None. I could not reproduce this because both my computers don't have this obscure problem. Love it 🙃

Copy link
Member

@azaleacolburn azaleacolburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the text in the boxes with the sliders could be smaller, or given more space. The sliders make it difficult to read.
Screenshot 2024-07-15 at 10 17 37 AM
Also, for some reason, I can't get all the signal types the toggle, only the ones that currently aren't pwm.
Screenshot 2024-07-15 at 10 22 28 AM

@BrandonPacewic
Copy link
Member Author

@Ewie21

Maybe the text in the boxes with the sliders could be smaller, or given more space. The sliders make it difficult to read.

The whole panel can be expanded by dragging it horizontally. For some reason vertical scaling is broken but horizontal works just fine.

Perhaps I could add something to automatically resize the panel?

Also, for some reason, I can't get all the signal types the toggle, only the ones that currently aren't pwm.

Not sure what you mean by this. There are three different signal types so it should become a drop down when you click on each one. Maybe this is fixed if you resize the panel to be larger horizontally so I never ran into this?

@azaleacolburn
Copy link
Member

@Ewie21

Maybe the text in the boxes with the sliders could be smaller, or given more space. The sliders make it difficult to read.

The whole panel can be expanded by dragging it horizontally. For some reason vertical scaling is broken but horizontal works just fine.

Perhaps I could add something to automatically resize the panel?

Also, for some reason, I can't get all the signal types the toggle, only the ones that currently aren't pwm.

Not sure what you mean by this. There are three different signal types so it should become a drop down when you click on each one. Maybe this is fixed if you resize the panel to be larger horizontally so I never ran into this?

👍 Got it

Copy link
Member

@HunterBarclay HunterBarclay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works perfect... except for one seemingly unrelated thing. When I was exporting the Kiwi drive, after exporting once and then reopening to see if the settings have saved, I noticed that when the export command is open, if I hover over the chassis of the bot, it changes my cursor to the select cursor (that you get when adding game pieces and joints)

Copy link
Member

@azaleacolburn azaleacolburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to make a ticket for making the config command panel bigger by default to make sure the buttons all always work. Great Work! LGTM!

Copy link
Member

@PepperLola PepperLola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it works, and I got the default utility knife design into Synthesis.

Screenshot 2024-07-18 at 3 12 45 PM

@HunterBarclay HunterBarclay merged commit 11c7a54 into dev Jul 22, 2024
13 checks passed
@HunterBarclay HunterBarclay deleted the branp/1685/joint-config-panel branch July 22, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants