Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APS File Upload #1004

Merged
merged 47 commits into from
Jul 19, 2024
Merged

APS File Upload #1004

merged 47 commits into from
Jul 19, 2024

Conversation

azaleacolburn
Copy link
Member

@azaleacolburn azaleacolburn commented Jun 28, 2024

Description

Functions to interface with APS data management, the main purpose is to upload mirabuf files to a users's hub, so they can be easily accessed by fission.
Every user has a hub, in their hub they have a project, in which there are folders, in which there are buckets. Files are inside buckets.

Objectives

  • Getters for hub ids, project ids, folder ids, file ids
  • Upload files to specific folder
  • Interface with the APS versioning system to upload new versions of mirabuf files

Testing Done

JIRA Issue

@azaleacolburn azaleacolburn self-assigned this Jun 28, 2024
@autodesk-chorus
Copy link

Chorus detected one or more security issues with this pull request. See the Checks tab for more details.

As a reminder, please follow the secure code review process as part of the Secure Coding Non-Negotiable requirement.

Copy link
Member

@HunterBarclay HunterBarclay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great. Slowly discovering more issues with the Simulator, now that we can bring in more bots.

@HunterBarclay
Copy link
Member

@Ewie21 Make sure you format

Copy link
Member

@BrandonPacewic BrandonPacewic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes in ConfigCommand.py that seem to be friction exporting changes. Did some of the friction re-implementation get accidently pushed to this branch?

@azaleacolburn
Copy link
Member Author

azaleacolburn commented Jul 17, 2024

There are some changes in ConfigCommand.py that seem to be friction exporting changes. Did some of the friction re-implementation get accidently pushed to this branch?

I removed a block of code that had already been commented out. The boolean changes were probably me testing to see what properties did. They shouldn't matter at all because all of that will get overriden by the friction override branch once it gets merged in though. I'll revert these changes just to be safe though.

Copy link
Member

@BrandonPacewic BrandonPacewic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still some problems with exporting a robot without APS and the docker container running. I believe that most of these problems were introduced in a different PR so no need to try and fix them here.

This is certainly good enough to get things started!

@BrandonPacewic BrandonPacewic mentioned this pull request Jul 18, 2024
4 tasks
@HunterBarclay HunterBarclay merged commit b496e77 into dev Jul 19, 2024
13 checks passed
@HunterBarclay HunterBarclay deleted the colbura/1721/aps-file-upload branch July 19, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants