-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
APS File Upload #1004
APS File Upload #1004
Conversation
…ura/1721/aps-file-upload
…ura/1721/aps-file-upload
Chorus detected one or more security issues with this pull request. See the Checks tab for more details. As a reminder, please follow the secure code review process as part of the Secure Coding Non-Negotiable requirement. |
…ura/1721/aps-file-upload
This reverts commit 7b85e62.
821517e
to
b75974f
Compare
This reverts commit b75974f.
…ura/1721/aps-file-upload
…ura/1721/aps-file-upload
…ura/1721/aps-file-upload
…ura/1721/aps-file-upload
…ura/1721/aps-file-upload
…odesk/synthesis into colbura/1721/aps-file-upload
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great. Slowly discovering more issues with the Simulator, now that we can bring in more bots.
@Ewie21 Make sure you format |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some changes in ConfigCommand.py
that seem to be friction exporting changes. Did some of the friction re-implementation get accidently pushed to this branch?
I removed a block of code that had already been commented out. The boolean changes were probably me testing to see what properties did. They shouldn't matter at all because all of that will get overriden by the friction override branch once it gets merged in though. I'll revert these changes just to be safe though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still some problems with exporting a robot without APS and the docker container running. I believe that most of these problems were introduced in a different PR so no need to try and fix them here.
This is certainly good enough to get things started!
Description
Functions to interface with APS data management, the main purpose is to upload mirabuf files to a users's hub, so they can be easily accessed by fission.
Every user has a hub, in their hub they have a project, in which there are folders, in which there are buckets. Files are inside buckets.
Objectives
Testing Done
JIRA Issue