Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Friction Data Export #1014

Merged
merged 26 commits into from
Jul 25, 2024
Merged

Conversation

azaleacolburn
Copy link
Member

@azaleacolburn azaleacolburn commented Jul 7, 2024

Description

Serializes the friction override for the wheels of a robot if the checkbox is clicked. Additionally this PR creates a friction lookup table for when friction isn't overrided.

The friction override is for the dynamic_friction and static_friction fields in the each ProtoMaterial in the exported mirabuf.

Todo:

  • Export Friction Override
  • Parse Friction Override in fission (Beyond the scope of the PR)

Testing Done

  • Friction correctly set in exporterOptions
  • Friction correctly serialized and deserialized (Not sure exactly how to test this without fission allowing a friction override in fission) (See above)

JIRA Issue

@azaleacolburn azaleacolburn requested review from HunterBarclay and a team as code owners July 7, 2024 23:36
@azaleacolburn azaleacolburn requested review from Dhruv-0-Arora and removed request for a team July 7, 2024 23:36
@azaleacolburn azaleacolburn self-assigned this Jul 7, 2024
@BrandonPacewic BrandonPacewic requested review from BrandonPacewic and PepperLola and removed request for Dhruv-0-Arora July 8, 2024 16:30
Copy link
Member

@BrandonPacewic BrandonPacewic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HunterBarclay Do we still want to do Fission integration as a part of this PR? If so we should mark this as draft and leave it for after the MVP.

@azaleacolburn azaleacolburn requested a review from a team as a code owner July 11, 2024 21:40
@azaleacolburn azaleacolburn requested review from BrandonPacewic and removed request for a team July 11, 2024 21:40
@azaleacolburn azaleacolburn requested a review from a team as a code owner July 12, 2024 15:55
@azaleacolburn azaleacolburn requested review from a-crowell and Dhruv-0-Arora and removed request for a team July 12, 2024 15:55
@autodesk-chorus
Copy link

Chorus detected one or more security issues with this pull request. See the Checks tab for more details.

As a reminder, please follow the secure code review process as part of the Secure Coding Non-Negotiable requirement.

Copy link
Member

@BrandonPacewic BrandonPacewic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dhruv-0-Arora Dhruv-0-Arora removed their request for review July 18, 2024 20:45
@PepperLola
Copy link
Member

I got this error when I set an override:

Synthesis.Material.getPhysicalMaterialData - ERROR - Failed:
  File ".../synthesis/exporter/SynthesisFusionAddin/src/Parser/SynthesisParser/Materials.py", line 99, in getPhysicalMaterialData
    physical_material.dynamic_friction = dynamic_friction_coeffs.get(fusion_material.name, 0.5)
    ^^^^^^^^^^^^^^^^^
NameError: name 'physical_material' is not defined

Also, are there supposed to be two buttons?
Screenshot 2024-07-24 at 3 29 20 PM

Copy link
Member

@BrandonPacewic BrandonPacewic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Let's get this in ASAP so I can finish #1032 🙃

Copy link
Member

@PepperLola PepperLola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@HunterBarclay HunterBarclay merged commit d031348 into dev Jul 25, 2024
13 checks passed
@HunterBarclay HunterBarclay deleted the colbura/1723/friction-data-mira-export branch July 25, 2024 21:20
BrandonPacewic added a commit that referenced this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants