-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Friction Data Export #1014
Friction Data Export #1014
Conversation
…ura/1723/friction-data-mira-export
This reverts commit 01aa9dd.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HunterBarclay Do we still want to do Fission integration as a part of this PR? If so we should mark this as draft and leave it for after the MVP.
…ura/1723/friction-data-mira-export
Chorus detected one or more security issues with this pull request. See the Checks tab for more details. As a reminder, please follow the secure code review process as part of the Secure Coding Non-Negotiable requirement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There appears to be aps auth stuff in here, perhaps a conflict with APS File Upload #1004?
…ura/1723/friction-data-mira-export
…ura/1723/friction-data-mira-export
I got this error when I set an override:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Let's get this in ASAP so I can finish #1032 🙃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Description
Serializes the friction override for the wheels of a robot if the checkbox is clicked. Additionally this PR creates a friction lookup table for when friction isn't overrided.
The friction override is for the
dynamic_friction
andstatic_friction
fields in the each ProtoMaterial in the exported mirabuf.Todo:
Parse Friction Override in fission(Beyond the scope of the PR)Testing Done
Friction correctly serialized and deserialized (Not sure exactly how to test this without fission allowing a friction override in fission)(See above)JIRA Issue