Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core Meta Panel & Gamepiece Configuration #1032

Merged
merged 29 commits into from
Jul 30, 2024
Merged

Conversation

BrandonPacewic
Copy link
Member

@BrandonPacewic BrandonPacewic commented Jul 18, 2024

  • Moved all remaining general and advanced options to be in one tab.
  • Everything is now structured like AARD-1685: Joint Config Panel #995 for easy (er) refactoring of ConfigCommand.py.
  • Integrated Friction Data Export #1014.
  • Made some small improvements to the way auto calculating robot weight works.
    • Now a checkbox instead of a button.
    • Choosing a different unit will now update he value input in real time.
  • Also refactored gamepiece config options to be structured like AARD-1685: Joint Config Panel #995.
  • Switching between Static and Dynamic export mode will toggle the visibility of the joint config tab, the gampiece config tab, and the dynamic export specific options.

I am still not 100% sure how I feel about structuring the UI in this way. Seems better than what we were doing before but I still think it can be improved upon.

I combined both these JIRA tickets to avoid any downtime in the gamepiece configuration functionality as the meta panel task would have overridden / deprecated some of the field configuration options.

To Test

This is a rather large PR here are somethings to make sure still work:

  1. Exporting a robot normally.
  2. Exporting a field normally.
  3. Selection of game pieces working as expected.

Most of these changes were structural so everything should look and feel like it always has.

Important

Blocked by:

JIRA Issue - Meta Panel
JIRA Issue - Gamepiece Config

Needed panel updates to be consistent. Will need to update this branch
after GH-995 is merged.
@BrandonPacewic BrandonPacewic changed the title AARD-1683: Core Meta Panel AARD-1683, AARD-1769: Core Meta Panel Jul 18, 2024
@BrandonPacewic BrandonPacewic changed the title AARD-1683, AARD-1769: Core Meta Panel AARD-1683, AARD-1769: Core Meta Panel & Gamepiece Configuration Jul 18, 2024
@BrandonPacewic BrandonPacewic mentioned this pull request Jul 25, 2024
4 tasks
@BrandonPacewic BrandonPacewic marked this pull request as ready for review July 26, 2024 00:27
@BrandonPacewic BrandonPacewic requested review from PepperLola and azaleacolburn and removed request for a team July 26, 2024 00:27
@BrandonPacewic BrandonPacewic changed the title AARD-1683, AARD-1769: Core Meta Panel & Gamepiece Configuration Core Meta Panel & Gamepiece Configuration Jul 26, 2024
Copy link
Member

@PepperLola PepperLola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good and works well. Automatically showing/hiding tabs based on static vs dynamic makes the process a lot simpler.

Maybe the auto calculate robot weight checkbox should go above the weight though? It's something the user would need to think about before the weight because changes to it impact whether or not they're able to manually input a weight.

@BrandonPacewic
Copy link
Member Author

Maybe the auto calculate robot weight checkbox should go above the weight though? It's something the user would need to think about before the weight because changes to it impact whether or not they're able to manually input a weight.

I would be open to suggestions, I made it this way because I felt it was weird to separate the other checkboxes but I could be persuaded otherwise.

@PepperLola
Copy link
Member

PepperLola commented Jul 26, 2024

I would be open to suggestions, I made it this way because I felt it was weird to separate the other checkboxes but I could be persuaded otherwise.

Yeah I was considering mentioning that in my reply. I think either way works when you've gone through the process already. The only reason I mention that is because my first instinct after hearing that it was a checkbox was to look above. It didn't take long to find it so I don't think it's super important.

@BrandonPacewic
Copy link
Member Author

Yeah I was considering mentioning that in my reply. I think either way works when you've gone through the process already. The only reason I mention that is because my first instinct after hearing that it was a checkbox was to look above. It didn't take long to find it so I don't think it's super important.

I would have liked to make the checkbox part of the row with the rest of the weight inputs but I had problems making a labeled checkbox. Something I can revisit later on.

Copy link
Member

@azaleacolburn azaleacolburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code quality here is substantially higher than some of the older code in ConfigCommand.py

@HunterBarclay HunterBarclay merged commit e82d794 into dev Jul 30, 2024
13 checks passed
@HunterBarclay HunterBarclay deleted the branp/1683/core-meta-panel branch July 30, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants