-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core Meta Panel & Gamepiece Configuration #1032
Conversation
Needed panel updates to be consistent. Will need to update this branch after GH-995 is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good and works well. Automatically showing/hiding tabs based on static vs dynamic makes the process a lot simpler.
Maybe the auto calculate robot weight checkbox should go above the weight though? It's something the user would need to think about before the weight because changes to it impact whether or not they're able to manually input a weight.
I would be open to suggestions, I made it this way because I felt it was weird to separate the other checkboxes but I could be persuaded otherwise. |
Yeah I was considering mentioning that in my reply. I think either way works when you've gone through the process already. The only reason I mention that is because my first instinct after hearing that it was a checkbox was to look above. It didn't take long to find it so I don't think it's super important. |
I would have liked to make the checkbox part of the row with the rest of the weight inputs but I had problems making a labeled checkbox. Something I can revisit later on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code quality here is substantially higher than some of the older code in ConfigCommand.py
ConfigCommand.py
.Static
andDynamic
export mode will toggle the visibility of the joint config tab, the gampiece config tab, and the dynamic export specific options.I am still not 100% sure how I feel about structuring the UI in this way. Seems better than what we were doing before but I still think it can be improved upon.
I combined both these JIRA tickets to avoid any downtime in the gamepiece configuration functionality as the meta panel task would have overridden / deprecated some of the field configuration options.
To Test
This is a rather large PR here are somethings to make sure still work:
Most of these changes were structural so everything should look and feel like it always has.
Important
Blocked by:
Types/**/*
->Types.py
#1045.JIRA Issue - Meta Panel
JIRA Issue - Gamepiece Config