Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AARD-1741: Exporter PIP Dependency Updates #1024

Merged
merged 12 commits into from
Aug 2, 2024
Merged

AARD-1741: Exporter PIP Dependency Updates #1024

merged 12 commits into from
Aug 2, 2024

Conversation

BrandonPacewic
Copy link
Member

@BrandonPacewic BrandonPacewic commented Jul 10, 2024 •
edited
Loading

  • Fixed a bug related to our protobuf version being very old and having no way of updating it outside of reinstalling Fusion.
  • Will now check the versions of all installed dependencies upon error and update them if necessary.
  • Integration with AARD-1735: Logging module updates #1010 for separate error messages depending on missing protoc files or improper dependencies.
  • Removed the need for deps.py to be a blank import.
  • Will now provide a separate error message if the complied proto files are missing rather than throw a could not install dependency error.

Testing Done

  • Running on pre-existing Windows.
  • Running on pre-existing Mac.
  • Running on fresh-install Windows.
  • Running on fresh-install Mac.

To Test For Reviewers:

  • Open Fusion with the extension as normal.
  • It should update / reinstall python-protobuf and ask you to restart Fusion.
    • Follow said instructions.
  • Upon reopening, everything should continue to work as intended.
  • If you like, update your system protoc version and run the build script (build.sh) from inside exporter/SynthesisFusionAddin/proto.
  • Upon restarting Fusion AGAIN, everything should still work normally.
    • Previously compiling the proto files with the most recent version of protoc would have broken the exporter.

Closes: JIRA Issue - Task
Fixes: JIRA Issue - Bug

@BrandonPacewic BrandonPacewic self-assigned this Jul 10, 2024
@BrandonPacewic BrandonPacewic mentioned this pull request Jul 22, 2024
Merged
@BrandonPacewic
Merge dev
c87165c 
* dev: (382 commits)
  Saves after deleting zone and formatting
  Render scoreboard option and remove dispatch
  Formatting
  Commented out destroy gamepiece in config
  Clean up and doc
  At long last, persistent points
  Updated logging module usage and removed auth token log
  Did not mean to add this
  General cleanups
  Fixed bug with fusion material overrides
  Now prompt for login before export start
  Format and lint fix
  Added actual intake and eject controls
  Fixed build error
  Re added configuration
  Avoid throwing a message box error for not being signed in
  fix friction override
  Refactor with `Types.py`
  Removed multi bot, fixed manage assemblies enough for now
  Update fission/src/ui/panels/DebugPanel.tsx
  ...
@BrandonPacewic
Integration with GH-1010
cee612d
@BrandonPacewic
Better import verification
a723159
@BrandonPacewic
Removed old deps file
517369b
@BrandonPacewic
Uncomment add import path
46b278b
@BrandonPacewic BrandonPacewic mentioned this pull request Jul 30, 2024
Closed
@BrandonPacewic
Merge dev
f47208d 
* dev: (42 commits)
  back to if else
  [HOTFIX 1] 7.0.0b1 (#1063)
  switch on constructor name
  ran formatter
  implemented suggestions
  ran formatter
  write to drivers when simulating with pwm TODO: integrate with motor config when max speeds are available instead of hardcoding 40
  Fixed the brain
  Formatted
  Readded code to avoid refresh
  fixed double auth request on rerender
  Renamed master to prod
  Formatted
  Little cleanup
  Finalizing analytics data for now
  Added APS and performance samples to analytics
  Formatted
  Fixed analytics, tested and validated
  Fixed APS bug
  Fixed unit testing failures
  ...
@BrandonPacewic
Final cleanups
a601ede
@BrandonPacewic
Remove unused function
08e9696
@BrandonPacewic BrandonPacewic marked this pull request as ready for review July 30, 2024 17:05
@BrandonPacewic BrandonPacewic requested review from PepperLola and azaleacolburn and removed request for a team July 30, 2024 17:05
BrandonPacewic
BrandonPacewic commented Jul 30, 2024
View reviewed changes
Copy link
Member Author

@BrandonPacewic BrandonPacewic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason the format workflow is failing on files that were not changed in this PR. Ignoring this for now and will investigate if this persists into dev. All code in this PR is formatted correctly.

PepperLola
PepperLola approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@PepperLola PepperLola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

azaleacolburn
azaleacolburn approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@azaleacolburn azaleacolburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HunterBarclay
Copy link
Member

@BrandonPacewic Black format validation is failing. I tried formatting but it did nothing.

@BrandonPacewic
Copy link
Member Author

@BrandonPacewic Black format validation is failing. I tried formatting but it did nothing.

See, #1024 (review).

@HunterBarclay HunterBarclay merged commit a8fb4d9 into dev Aug 2, 2024
12 of 13 checks passed
@HunterBarclay HunterBarclay deleted the branp/1741/exporter-deps-update branch August 2, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azaleacolburn azaleacolburn azaleacolburn approved these changes

@PepperLola PepperLola PepperLola approved these changes

@HunterBarclay HunterBarclay Awaiting requested review from HunterBarclay HunterBarclay is a code owner

Assignees

@BrandonPacewic BrandonPacewic

Labels
bug exporter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BrandonPacewic @HunterBarclay @PepperLola @azaleacolburn