-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Versim setup and VCS fixes #180
Conversation
Do we have any kind of CI that tests simulation device? |
There could be for Versim, however it's not possible for VCS since only some machines have the licenses |
Left a few nit comments. As a general comment, I am not sure whether we have some kind of docs (at least I am not aware of it) on how to setup and run our simulation devices. I think this would be very useful. You don't have to add it in this PR, but you can maybe open the issue to add simulation docs and slowly build it when you have time. If there are already some docs on it, just link it somehow through main README of the repo |
Yes there is a backend gitlab repo that contains instructions on how to run the simulator. I will link those somewhere in our readme. |
469e54b
to
67183b7
Compare
67183b7
to
bb4318e
Compare
- write_to_device signature wasn't changed in umd cleanup - fix simulation tests to not use test::utils read_from_device
bb4318e
to
dd9faa7
Compare
As discussed here: #180 (comment) Old setup involved building the `flatc` executable and then manually running it to generate the header file. Now it is integrated into the cmake build flow and `tt_simulation_device_generated.h` will be generated as a dependency of `device` target.
Changes for Versim setup: - modify `tt_SimulationDevice` start and close device - update the flatbuffer used to communicate with the backend Changes for VCS fixes: - forgot to modify `write_to_device` signature when I did my initial UMD cleanup - revert `test_simulation_device` to not use `test::utils::read_from_device` since it's using simulation not silicon device
As discussed here: #180 (comment) Old setup involved building the `flatc` executable and then manually running it to generate the header file. Now it is integrated into the cmake build flow and `tt_simulation_device_generated.h` will be generated as a dependency of `device` target.
Changes for Versim setup:
tt_SimulationDevice
start and close deviceChanges for VCS fixes:
write_to_device
signature when I did my initial UMD cleanuptest_simulation_device
to not usetest::utils::read_from_device
since it's using simulation not silicon device