Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versim setup and VCS fixes #180

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Versim setup and VCS fixes #180

merged 1 commit into from
Oct 30, 2024

Conversation

vtangTT
Copy link
Contributor

@vtangTT vtangTT commented Oct 17, 2024

Changes for Versim setup:

  • modify tt_SimulationDevice start and close device
  • update the flatbuffer used to communicate with the backend

Changes for VCS fixes:

  • forgot to modify write_to_device signature when I did my initial UMD cleanup
  • revert test_simulation_device to not use test::utils::read_from_device since it's using simulation not silicon device

@broskoTT
Copy link
Contributor

Do we have any kind of CI that tests simulation device?

@vtangTT
Copy link
Contributor Author

vtangTT commented Oct 18, 2024

Do we have any kind of CI that tests simulation device?

There could be for Versim, however it's not possible for VCS since only some machines have the licenses

tests/simulation/test_simulation_device.cpp Outdated Show resolved Hide resolved
tests/simulation/test_simulation_device.cpp Outdated Show resolved Hide resolved
tests/simulation/test_simulation_device.cpp Outdated Show resolved Hide resolved
tests/simulation/test_simulation_device.cpp Outdated Show resolved Hide resolved
@pjanevskiTT
Copy link
Contributor

Left a few nit comments. As a general comment, I am not sure whether we have some kind of docs (at least I am not aware of it) on how to setup and run our simulation devices. I think this would be very useful. You don't have to add it in this PR, but you can maybe open the issue to add simulation docs and slowly build it when you have time. If there are already some docs on it, just link it somehow through main README of the repo

@vtangTT
Copy link
Contributor Author

vtangTT commented Oct 25, 2024

Left a few nit comments. As a general comment, I am not sure whether we have some kind of docs (at least I am not aware of it) on how to setup and run our simulation devices. I think this would be very useful. You don't have to add it in this PR, but you can maybe open the issue to add simulation docs and slowly build it when you have time. If there are already some docs on it, just link it somehow through main README of the repo

Yes there is a backend gitlab repo that contains instructions on how to run the simulator. I will link those somewhere in our readme.

@vtangTT vtangTT force-pushed the vtangTT/versim_setup branch 3 times, most recently from 469e54b to 67183b7 Compare October 28, 2024 18:51
README.md Show resolved Hide resolved
- write_to_device signature wasn't changed in umd cleanup
- fix simulation tests to not use test::utils read_from_device
@vtangTT vtangTT merged commit f08a866 into main Oct 30, 2024
18 checks passed
@vtangTT vtangTT deleted the vtangTT/versim_setup branch October 30, 2024 20:51
@vtangTT vtangTT restored the vtangTT/versim_setup branch October 30, 2024 20:52
vtangTT added a commit that referenced this pull request Oct 31, 2024
As discussed here:
#180 (comment)

Old setup involved building the `flatc` executable and then manually
running it to generate the header file.

Now it is integrated into the cmake build flow and
`tt_simulation_device_generated.h` will be generated as a dependency of
`device` target.
mbezuljTT pushed a commit that referenced this pull request Nov 1, 2024
Changes for Versim setup:
- modify `tt_SimulationDevice` start and close device
- update the flatbuffer used to communicate with the backend

Changes for VCS fixes:
- forgot to modify `write_to_device` signature when I did my initial UMD
cleanup
- revert `test_simulation_device` to not use
`test::utils::read_from_device` since it's using simulation not silicon
device
mbezuljTT pushed a commit that referenced this pull request Nov 1, 2024
As discussed here:
#180 (comment)

Old setup involved building the `flatc` executable and then manually
running it to generate the header file.

Now it is integrated into the cmake build flow and
`tt_simulation_device_generated.h` will be generated as a dependency of
`device` target.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants