Generate fbs header file through cmake during build flow #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtangTT
changed the title
vtangTT
force-pushed
the
vtangTT/fbs_generate
branch
4 times, most recently
from
1ddcb2a
to
bfc1a3d
Compare
vtangTT
commented
Oct 29, 2024
vtangTT
force-pushed
the
vtangTT/fbs_generate
branch
from
d8a83ba
to
947db62
Compare
afuller-TT
reviewed
Oct 29, 2024
vtangTT
force-pushed
the
vtangTT/fbs_generate
branch
2 times, most recently
from
81f1968
to
633dd06
Compare
|
This PR will be ready to go out after #224 that privatizes nng and fbs headers |
pjanevskiTT
approved these changes
Oct 30, 2024
vtangTT
force-pushed
the
vtangTT/fbs_generate
branch
from
633dd06
to
54ffde3
Compare
vtangTT
force-pushed
the
vtangTT/fbs_generate
branch
from
54ffde3
to
214390b
Compare
vtangTT
force-pushed
the
vtangTT/fbs_generate
branch
from
214390b
to
2b63056
Compare
mbezuljTT
pushed a commit
that referenced
this pull request
Nov 1, 2024
As discussed here: #180 (comment) Old setup involved building the `flatc` executable and then manually running it to generate the header file. Now it is integrated into the cmake build flow and `tt_simulation_device_generated.h` will be generated as a dependency of `device` target.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here: #180 (comment)
Old setup involved building the
flatcexecutable and then manually running it to generate the header file.Now it is integrated into the cmake build flow and
tt_simulation_device_generated.hwill be generated as a dependency ofdevicetarget.