Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: post compilation size limit validation #298

Closed
wants to merge 1 commit into from
Closed

feat: post compilation size limit validation #298

wants to merge 1 commit into from

Conversation

ArniStarkware
Copy link
Contributor

@ArniStarkware ArniStarkware commented Jun 27, 2024 •
edited by hkrasniker-starkware
Loading

This change is Reviewable

This was referenced Jun 27, 2024
Merged
Merged
Merged
Merged
Closed
@ArniStarkware Graphite App
Copy link
Contributor Author

ArniStarkware commented Jun 27, 2024 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ArniStarkware and the rest of your teammates on Graphite Graphite

@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.87234% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.56%. Comparing base (5c3f88c) to head (05697a3).

Files Patch % Lines
crates/gateway/src/config.rs 95.65% 1 Missing ⚠️
Additional details and impacted files 
@@                                   Coverage Diff                                    @@
##           arni/declare/compilation/add_fixture_in_compile_test     #298      +/-   ##
========================================================================================
+ Coverage                                                 81.11%   81.56%   +0.44%     
========================================================================================
  Files                                                        42       42              
  Lines                                                      1790     1833      +43     
  Branches                                                   1790     1833      +43     
========================================================================================
+ Hits                                                       1452     1495      +43     
  Misses                                                      265      265              
  Partials                                                     73       73

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArniStarkware ArniStarkware force-pushed the arni/declare/compute_compiled_class_hash branch 2 times, most recently from 4e760df to f8db27c Compare June 27, 2024 15:41
@ArniStarkware ArniStarkware force-pushed the arni/declare/post_compilation/size_validation branch from 6ec8522 to d8de282 Compare June 27, 2024 15:41
@ArniStarkware ArniStarkware mentioned this pull request Jun 27, 2024
Closed
@ArniStarkware ArniStarkware force-pushed the arni/declare/post_compilation/size_validation branch from d8de282 to 826d06e Compare June 27, 2024 15:48
@ArniStarkware ArniStarkware force-pushed the arni/declare/compute_compiled_class_hash branch from f8db27c to 358bcbd Compare June 30, 2024 08:50
@ArniStarkware ArniStarkware mentioned this pull request Jun 30, 2024
Closed
@ArniStarkware ArniStarkware force-pushed the arni/declare/post_compilation/size_validation branch from 826d06e to ffcf3b3 Compare June 30, 2024 09:13
@ArniStarkware ArniStarkware force-pushed the arni/declare/compute_compiled_class_hash branch from 358bcbd to dffdc5a Compare June 30, 2024 09:14
@ArniStarkware ArniStarkware force-pushed the arni/declare/post_compilation/size_validation branch from ffcf3b3 to dc939e7 Compare June 30, 2024 09:14
@ArniStarkware ArniStarkware force-pushed the arni/declare/compute_compiled_class_hash branch from dffdc5a to b12db17 Compare June 30, 2024 09:26
@ArniStarkware ArniStarkware force-pushed the arni/declare/post_compilation/size_validation branch 3 times, most recently from 4e8e572 to ddda372 Compare July 1, 2024 08:30
@ArniStarkware ArniStarkware changed the base branch from arni/declare/compute_compiled_class_hash to main July 1, 2024 08:30
@ArniStarkware ArniStarkware force-pushed the arni/declare/post_compilation/size_validation branch from ddda372 to ab37864 Compare July 2, 2024 08:46
This was referenced Jul 2, 2024
Merged
Closed
Closed
@ArniStarkware ArniStarkware force-pushed the arni/declare/post_compilation/size_validation branch 4 times, most recently from b2ca15c to f249947 Compare July 7, 2024 12:10
@ArniStarkware ArniStarkware force-pushed the arni/declare/post_compilation/size_validation branch from 10697c5 to 825012e Compare July 18, 2024 12:48
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/restruct_gateway_compiler branch from 989780d to 00a1079 Compare July 18, 2024 13:28
@ArniStarkware ArniStarkware force-pushed the arni/declare/post_compilation/size_validation branch from 825012e to 14ff21e Compare July 18, 2024 13:29
dafnamatsry
dafnamatsry approved these changes Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@dafnamatsry dafnamatsry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r16, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Yael-Starkware and @yair-starkware)

@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/restruct_gateway_compiler branch from 00a1079 to c1bd861 Compare July 22, 2024 10:36
@ArniStarkware ArniStarkware force-pushed the arni/declare/post_compilation/size_validation branch from 14ff21e to 1973ad9 Compare July 22, 2024 10:36
@ArniStarkware ArniStarkware changed the base branch from arni/declare/compilation/restruct_gateway_compiler to arni/declare/compilation/add_fixture_in_compile_test July 22, 2024 10:36
@ArniStarkware ArniStarkware mentioned this pull request Jul 22, 2024
Closed
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/add_fixture_in_compile_test branch from f29689e to 59625db Compare July 22, 2024 11:07
@ArniStarkware ArniStarkware force-pushed the arni/declare/post_compilation/size_validation branch from 1973ad9 to 8f817da Compare July 22, 2024 11:07
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/add_fixture_in_compile_test branch from 59625db to 39416a2 Compare July 22, 2024 11:14
@ArniStarkware ArniStarkware force-pushed the arni/declare/post_compilation/size_validation branch from 8f817da to 77d31d9 Compare July 22, 2024 11:14
dafnamatsry
dafnamatsry approved these changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@dafnamatsry dafnamatsry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r17, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Yael-Starkware and @yair-starkware)

@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/add_fixture_in_compile_test branch from 39416a2 to 5d26fb0 Compare July 23, 2024 10:47
@ArniStarkware ArniStarkware force-pushed the arni/declare/post_compilation/size_validation branch from 77d31d9 to b34b37f Compare July 23, 2024 10:47
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/add_fixture_in_compile_test branch from 5d26fb0 to 621c3f4 Compare July 23, 2024 11:07
@ArniStarkware ArniStarkware force-pushed the arni/declare/post_compilation/size_validation branch from b34b37f to 9a5fb02 Compare July 23, 2024 11:07
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/add_fixture_in_compile_test branch from 621c3f4 to 56b722a Compare July 23, 2024 11:10
@ArniStarkware ArniStarkware force-pushed the arni/declare/post_compilation/size_validation branch from 9a5fb02 to 3ad7790 Compare July 23, 2024 11:10
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/add_fixture_in_compile_test branch from 56b722a to 48ce9b6 Compare July 23, 2024 13:54
@ArniStarkware ArniStarkware force-pushed the arni/declare/post_compilation/size_validation branch from 3ad7790 to 2a2be69 Compare July 23, 2024 13:55
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/add_fixture_in_compile_test branch from 48ce9b6 to 5c3f88c Compare July 23, 2024 14:16
@ArniStarkware ArniStarkware force-pushed the arni/declare/post_compilation/size_validation branch from 2a2be69 to 05697a3 Compare July 23, 2024 14:16
@ArniStarkware ArniStarkware mentioned this pull request Jul 23, 2024
Closed
yair-starkware
yair-starkware approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@yair-starkware yair-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r14, 2 of 3 files at r15, 4 of 4 files at r18, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Yael-Starkware)

@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/add_fixture_in_compile_test branch from 5c3f88c to 4f81cff Compare August 1, 2024 10:25
@ArniStarkware ArniStarkware force-pushed the arni/declare/post_compilation/size_validation branch from 05697a3 to 446586c Compare August 1, 2024 10:26
@ArniStarkware ArniStarkware mentioned this pull request Aug 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dafnamatsry dafnamatsry dafnamatsry approved these changes

@yair-starkware yair-starkware yair-starkware approved these changes

@Yael-Starkware Yael-Starkware Awaiting requested review from Yael-Starkware

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ArniStarkware @codecov-commenter @Yael-Starkware @dafnamatsry @yair-starkware