feat: declare post compilation prime validation

[ArniStarkware]

This change is 

[ArniStarkware]

• feat: declare post compilation prime validation #297 👈
• chore: code to compilation file from gateway #344 : 2 other dependent PRs (#319 , #348 )
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ArniStarkware and the rest of your teammates on Graphite

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.56%. Comparing base (9852d18) to head (04deeb9).

Files	Patch %	Lines
crates/gateway/src/compilation.rs	85.71%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #297   +/-   ##
=======================================
  Coverage   83.55%   83.56%           
=======================================
  Files          37       37           
  Lines        1770     1777    +7     
  Branches     1770     1777    +7     
=======================================
+ Hits         1479     1485    +6     
- Misses        212      213    +1     
  Partials       79       79           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Yael-Starkware]

Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @ArniStarkware and @dafnamatsry)

---

crates/gateway/src/gateway.rs line 227 at r1 (raw file):

        return Err(GatewayError::InvalidPrime { prime, expected_prime });
    }

Can you explain what this check is? what is the meaning of prime here?

[Yael-Starkware]

Reviewable status: 0 of 5 files reviewed, 2 unresolved discussions (waiting on @ArniStarkware and @dafnamatsry)

---

crates/gateway/src/gateway.rs line 212 at r1 (raw file):

    for entry_point in entry_points_iterator {
        let builtins = &entry_point.builtins;
        println!("{builtins:?}");

remove.

Code quote:

println!("{builtins:?}");

[ArniStarkware]

Reviewable status: 0 of 5 files reviewed, 2 unresolved discussions (waiting on @dafnamatsry and @Yael-Starkware)

---

crates/gateway/src/gateway.rs line 212 at r1 (raw file):

Previously, Yael-Starkware (YaelD) wrote…

remove.

Done.

[ArniStarkware]

crates/gateway/src/gateway.rs line 227 at r1 (raw file):

Previously, Yael-Starkware (YaelD) wrote…

Can you explain what this check is? what is the meaning of prime here?

This was first referenced here: https://github.com/starkware-industries/starkware/pull/17777

[ArniStarkware]

crates/gateway/src/gateway.rs line 227 at r1 (raw file):

Previously, ArniStarkware (Arnon Hod) wrote…

This was first referenced here: https://github.com/starkware-industries/starkware/pull/17777

One step back. This validation was copied from the Python code.

[dafnamatsry]

Reviewed 2 of 6 files at r4, 4 of 4 files at r5, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @ArniStarkware and @Yael-Starkware)

---

crates/gateway/src/compilation.rs line 96 at r5 (raw file):

    let prime = contract_class.prime.clone();
    let expected_prime =
        BigUint::from_str_radix(&PRIME_STR[2..], 16).expect("Error parsing field prime.");

Can this be a constant?

Code quote:

BigUint::from_str_radix(&PRIME_STR[2..], 16).expect("Error parsing field prime.");

[ArniStarkware]

Reviewable status: 1 of 6 files reviewed, 3 unresolved discussions (waiting on @dafnamatsry, @Yael-Starkware, and @Yoni-Starkware)

---

crates/gateway/src/gateway.rs line 227 at r1 (raw file):

Previously, ArniStarkware (Arnon Hod) wrote…

One step back. This validation was copied from the Python code.

@Yoni-Starkware agrees this validation is no longer needed. See: https://starkwareindustries.slack.com/archives/C03D7FDE1EZ/p1721116020563769

[ArniStarkware]

This validation is not needed for Cairo 1 contracts.

The prime used during the compilation into CASM is independent of the transaction.