Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add declare_tx fixture to compilation tests #515

Conversation

ArniStarkware
Copy link
Contributor

@ArniStarkware ArniStarkware commented Jul 22, 2024

This change is Reviewable

Copy link
Contributor Author

ArniStarkware commented Jul 22, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ArniStarkware and the rest of your teammates on Graphite Graphite

@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.11%. Comparing base (ea16b37) to head (5c3f88c).

Additional details and impacted files
@@                            Coverage Diff                            @@
##           arni/declare/remove_redundent_validation     #515   +/-   ##
=========================================================================
  Coverage                                     81.11%   81.11%           
=========================================================================
  Files                                            42       42           
  Lines                                          1790     1790           
  Branches                                       1790     1790           
=========================================================================
  Hits                                           1452     1452           
  Misses                                          265      265           
  Partials                                         73       73           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/restruct_gateway_compiler branch from c1bd861 to 4ab9474 Compare July 22, 2024 11:06
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/add_fixture_in_compile_test branch from f29689e to 59625db Compare July 22, 2024 11:07
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/restruct_gateway_compiler branch from 4ab9474 to 33642fb Compare July 22, 2024 11:14
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/add_fixture_in_compile_test branch from 59625db to 39416a2 Compare July 22, 2024 11:14
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/restruct_gateway_compiler branch from 33642fb to 7644b4d Compare July 23, 2024 10:47
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/add_fixture_in_compile_test branch 2 times, most recently from 5d26fb0 to 621c3f4 Compare July 23, 2024 11:07
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/restruct_gateway_compiler branch from 7644b4d to d6075c4 Compare July 23, 2024 11:10
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/add_fixture_in_compile_test branch 2 times, most recently from 56b722a to 48ce9b6 Compare July 23, 2024 13:54
@ArniStarkware ArniStarkware changed the base branch from arni/declare/compilation/restruct_gateway_compiler to main July 23, 2024 13:55
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/add_fixture_in_compile_test branch from 48ce9b6 to 5c3f88c Compare July 23, 2024 14:16
@ArniStarkware ArniStarkware changed the base branch from main to arni/declare/remove_redundent_validation July 23, 2024 14:16
Copy link
Contributor

@Yael-Starkware Yael-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dafnamatsry and @yair-starkware)

Copy link
Contributor

@yair-starkware yair-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dafnamatsry)

Copy link
Collaborator

@dafnamatsry dafnamatsry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)

@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/add_fixture_in_compile_test branch from 5c3f88c to 4f81cff Compare August 1, 2024 10:25
@ArniStarkware ArniStarkware changed the base branch from arni/declare/remove_redundent_validation to main August 1, 2024 10:26
@ArniStarkware
Copy link
Contributor Author

Another branch was merged into sequencer repo.

@ArniStarkware ArniStarkware deleted the arni/declare/compilation/add_fixture_in_compile_test branch August 21, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants