Enable source module imports in stepper #1453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5710720150
💛 - Coveralls |
ianyong
reviewed
Jul 24, 2023
There was a problem hiding this comment.
This PR is missing a description and test cases, so I haven't fully reviewed it because I lack context of what is going on here.
I have some code quality comments from a quick look through, with the use of type assertions being one that might take a bit of effort to resolve.
Ziwen510
requested review from
martin-henz and
ianyong
and removed request for
ianyong
|
As discussed, let's handle the refactoring later, see #1457. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request integrates source module imports within the stepper. The module objects manifest in their REPL string representation in the stepper. Any generated functions in the middle of the process are displayed as
[Function].The test cases are commented out before mock module functions become available.