New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace type assertions with type narrowing #1457

Open

Ziwen510 opened this issue Jul 30, 2023 · 0 comments

Labels

Enhancement security

Contributor

Ziwen510 commented Jul 30, 2023 •

edited

Loading

Type assertions are everywhere in our code (eg. stepper/stepper.ts).

They defeat the point of having a type system by silencing the compiler on type errors. Type assertions only affect the static semantics of a program but not the dynamic semantics, meaning that even though the TypeScript compiler doesn't complain, our program could run into runtime type errors. Instead, we should make use of type narrowing.
See pull request #1453

Ziwen510 added the security label

Ziwen510 mentioned this issue

Enable source module imports in stepper #1453

Merged

martin-henz added the Enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment