Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: option to (partly) prevent syncing and translation #32

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hphoeksma
Copy link
Contributor

Fixes: #31

@gradinarufelix
Copy link
Collaborator

Sorry for the long delay. I had a look at it now and I like the idea.

My only question is: do you think it is enough to just test the parent node? In my opinion, it has to be recursive. In other words, once I set this option on a content node, it disabled translations for all content nodes below to the n-th layer. Otherwise, you could have the following case:

  • Document Node
    • Content Collection
      • Button Group
        • Button

If you enabled preventTranslation on the collection, it would hold for the ButtonGroup but not for the Button.

Am I right here or did I misunderstand something in your code?

@gradinarufelix gradinarufelix self-assigned this Jan 25, 2024
@hphoeksma
Copy link
Contributor Author

Hmm... the idea was that once a collection is marked as prevented, nothing in that collection is translated. But it could be I did not test / need it recursively...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FEATURE: Prevent synchronisation & automatic translations for parts of a page
2 participants