-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
h2134 - None of the functions in SuperPool checks pause state #270
Labels
Has Duplicates
A valid issue with 1+ other issues describing the same vulnerability
Medium
A Medium severity issue.
Reward
A payout will be made for this issue
Sponsor Confirmed
The sponsor acknowledged this issue is valid
Will Fix
The sponsor confirmed this issue will be fixed
Comments
github-actions
bot
added
Has Duplicates
A valid issue with 1+ other issues describing the same vulnerability
Medium
A Medium severity issue.
labels
Sep 5, 2024
This was referenced Sep 5, 2024
Closed
oxkmmm -
SuperPool
has the ability to be paused but does not stop any functions when pausing it
#143
Closed
sherlock-admin3
added
Sponsor Confirmed
The sponsor acknowledged this issue is valid
Will Fix
The sponsor confirmed this issue will be fixed
labels
Sep 10, 2024
sherlock-admin4
changed the title
Abundant Hazel Newt - None of the functions in SuperPool checks pause state
h2134 - None of the functions in SuperPool checks pause state
Sep 15, 2024
The protocol team fixed this issue in the following PRs/commits: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Has Duplicates
A valid issue with 1+ other issues describing the same vulnerability
Medium
A Medium severity issue.
Reward
A payout will be made for this issue
Sponsor Confirmed
The sponsor acknowledged this issue is valid
Will Fix
The sponsor confirmed this issue will be fixed
h2134
Medium
None of the functions in SuperPool checks pause state
Summary
None of the functions in SuperPool checks pause state.
Vulnerability Detail
SuperPool
contract isPausable
.SuperPool.sol#L25:
togglePause()
is implemented to toggle pause state of theSuperPool
.SuperPool.sol#L163-L167:
However, none of the functions in
SuperPool
checks the pause state, renders the pause functionality meaningless. As confirmed with sponsor, pause state checking should be implemented on some functions.Impact
None of the functions in
SuperPool
can be paused.Code Snippet
https://github.com/sherlock-audit/2024-08-sentiment-v2/blob/main/protocol-v2/src/SuperPool.sol#L25
Tool used
Manual Review
Recommendation
It is recommend to implemented pause state checking on some of the functions, for example, and
deposit()
andmint()
functions:SuperPool.sol#L258:
SuperPool.sol#L269:
The text was updated successfully, but these errors were encountered: