Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0xDemon - The superPool contract cannot be paused and unpaused completely when needed (i.e. superPool is hacked) because none of the functions in it use the whenNotPaused and whenPaused modifiers #520

Closed
sherlock-admin2 opened this issue Aug 24, 2024 · 0 comments
Closed

0xDemon - The superPool contract cannot be paused and unpaused completely when needed (i.e. superPool is hacked) because none of the functions in it use the whenNotPaused and whenPaused modifiers #520

sherlock-admin2 opened this issue Aug 24, 2024 · 0 comments
Labels
Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label Medium A Medium severity issue. Reward A payout will be made for this issue

Comments

@sherlock-admin2
Copy link
Contributor

sherlock-admin2 commented Aug 24, 2024 •
edited by sherlock-admin4
Loading

0xDemon

Medium

The superPool contract cannot be paused and unpaused completely when needed (i.e. superPool is hacked) because none of the functions in it use the whenNotPaused and whenPaused modifiers

Summary

The superPool contract cannot be paused and unpaused completely when needed (i.e. superPool is hacked) because none of the functions in it use the whenNotPaused and whenPaused modifiers

Root Cause

superPool contract inherits from Pausable , but none of the functions in it use the whenNotPaused and whenPaused modifiers

Internal pre-conditions

No response

External pre-conditions

No response

Attack Path

No response

Impact

The superPool contract cannot be paused and unpaused completely

PoC

No response

Mitigation

Consider adding whenNotPaused and whenPaused modifiers to critical functions (i.e deposit, mint, withdraw, redeem, and reallocate)

Duplicate of #270
@github-actions github-actions bot closed this as completed Sep 5, 2024
@github-actions github-actions bot added Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label Medium A Medium severity issue. labels Sep 5, 2024
@sherlock-admin4 sherlock-admin4 changed the title Droll Mocha Goblin - The superPool contract cannot be paused and unpaused completely when needed (i.e. superPool is hacked) because none of the functions in it use the whenNotPaused and whenPaused modifiers 0xDemon - The superPool contract cannot be paused and unpaused completely when needed (i.e. superPool is hacked) because none of the functions in it use the whenNotPaused and whenPaused modifiers Sep 15, 2024
@sherlock-admin4 sherlock-admin4 added the Reward A payout will be made for this issue label Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label Medium A Medium severity issue. Reward A payout will be made for this issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sherlock-admin2 @sherlock-admin4