EgisSecurity - SuperPool has a togglePause function, but lack whenNotPaused modifier

[sherlock-admin2]

EgisSecurity

Medium

SuperPool has a togglePause function, but lack whenNotPaused modifier

Summary

SuperPool inherits from Pausable, which provides a pausability. The problem is that protocol has not used whenNotPaused modifier to any of the function, which makes the whole Pausable functionality useless. Contract also have togglePaused function, which would be useless. The issue impact is that contract does not work as expected. Issue is confirmed by the sponsor:
sponsor confirmation

Root Cause

Missed whenNotPaused modifier on the expected functions.

Internal pre-conditions

None

External pre-conditions

None

Attack Path

Users are able to deposit even if the contract is paused.

Impact

• Breaks protocol expected functionality
• Waste gas on deployment of functionality, which cannot be used

PoC

No response

Mitigation

Implement the modifier to all functions, which you want to limit in paused state.

Duplicate of #270