You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
DuplicateA valid issue that is a duplicate of an issue with `Has Duplicates` labelMediumA Medium severity issue.RewardA payout will be made for this issue
SuperPool has a togglePause function, but lack whenNotPaused modifier
Summary
SuperPool inherits from Pausable, which provides a pausability. The problem is that protocol has not used whenNotPaused modifier to any of the function, which makes the whole Pausable functionality useless. Contract also have togglePaused function, which would be useless. The issue impact is that contract does not work as expected. Issue is confirmed by the sponsor: sponsor confirmation
Root Cause
Missed whenNotPaused modifier on the expected functions.
Internal pre-conditions
None
External pre-conditions
None
Attack Path
Users are able to deposit even if the contract is paused.
Impact
Breaks protocol expected functionality
Waste gas on deployment of functionality, which cannot be used
PoC
No response
Mitigation
Implement the modifier to all functions, which you want to limit in paused state.
sherlock-admin4
changed the title
Bitter Sandstone Worm - SuperPool has a togglePause function, but lack whenNotPaused modifier
EgisSecurity - SuperPool has a togglePause function, but lack whenNotPaused modifier
Sep 15, 2024
DuplicateA valid issue that is a duplicate of an issue with `Has Duplicates` labelMediumA Medium severity issue.RewardA payout will be made for this issue
EgisSecurity
Medium
SuperPool
has atogglePause
function, but lackwhenNotPaused
modifierSummary
SuperPool
inherits fromPausable
, which provides a pausability. The problem is that protocol has not usedwhenNotPaused
modifier to any of the function, which makes the wholePausable
functionality useless. Contract also have togglePaused function, which would be useless. The issue impact is that contract does not work as expected. Issue is confirmed by the sponsor:sponsor confirmation
Root Cause
Missed
whenNotPaused
modifier on the expected functions.Internal pre-conditions
None
External pre-conditions
None
Attack Path
Users are able to deposit even if the contract is paused.
Impact
PoC
No response
Mitigation
Implement the modifier to all functions, which you want to limit in paused state.
Duplicate of #270
The text was updated successfully, but these errors were encountered: