000000 - Superpool can not be paused despite the implemented functionality

[sherlock-admin3]

000000

Medium

Superpool can not be paused despite the implemented functionality

Summary

Superpool can not be paused despite the implemented functionality

Vulnerability Detail

The Superpool contract is supposed to be pausable as first of all, it inherits the Pausable contract and it also has the following function:

function togglePause() external onlyOwner {
        if (Pausable.paused()) Pausable._unpause();
        else Pausable._pause();
    }

However, in order for any of the functions to not work whenever the contract is paused/not paused, they have to implement the whenNotPaused and whenPaused modifiers. None of the functions do that, thus the contract can not actually be paused despite the implemented functionality.

Impact

Superpool can not be paused despite the implemented functionality

Code Snippet

https://github.com/sherlock-audit/2024-08-sentiment-v2/blob/25a0c8aeaddec273c5318540059165696591ecfb/protocol-v2/src/SuperPool.sol#L25

Tool used

Manual Review

Recommendation

Use the whenNotPaused and whenPaused modifiers

Duplicate of #270