Don't assert on ticks overshoot during record on AMD #3828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On AMD, we regularly overshoot the programmed ticks counter. We print this as a warning earlier in the function. However, the warning is ineffective, because we have an assert with the same condition later in the function. Adjust the check for that error condition to only fire during replay, not record (where it is supposed to be non-fatal).
|
Should resolve record failure seen at e.g. https://buildkite.com/julialang/julia-master/builds/40117#01920b75-60d9-42f0-a81c-c854b196ce20. cc @JeffBezanson |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On AMD, we regularly overshoot the programmed ticks counter. We print this as a warning earlier in the function. However, the warning is ineffective, because we have an assert with the same condition later in the function. Adjust the check for that error condition to only fire during replay, not record (where it is supposed to be non-fatal).