Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't assert on ticks overshoot during record on AMD #3828

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Don't assert on ticks overshoot during record on AMD #3828

merged 1 commit into from
Sep 20, 2024

Commits on Sep 20, 2024

  1. Don't assert on ticks overshoot during record on AMD 

    On AMD, we regularly overshoot the programmed ticks counter.
We print this as a warning earlier in the function. However,
the warning is ineffective, because we have an assert with the
same condition later in the function. Adjust the check for
that error condition to only fire during replay, not record
(where it is supposed to be non-fatal).
    @Keno
    Keno committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    5ddd1ef View commit details
    Browse the repository at this point in the history