Skip to content

Commit

Permalink
Don't assert on ticks overshoot during record on AMD
Browse files Browse the repository at this point in the history
On AMD, we regularly overshoot the programmed ticks counter.
We print this as a warning earlier in the function. However,
the warning is ineffective, because we have an assert with the
same condition later in the function. Adjust the check for
that error condition to only fire during replay, not record
(where it is supposed to be non-fatal).
  • Loading branch information
Keno authored and rocallahan committed Sep 20, 2024
1 parent b21e46e commit 07415f5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/PerfCounters.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1066,7 +1066,7 @@ Ticks PerfCounters::read_ticks(Task* t, Error* error) {
ret = measure_val;
}
}
if (ret > adjusted_counting_period) {
if (!t->session().is_recording() && ret > adjusted_counting_period) {
if (error && (perf_attrs[pmu_index].pmu_flags & PMU_SKID_UNBOUNDED)) {
*error = Error::Transient;
} else {
Expand Down

0 comments on commit 07415f5

Please sign in to comment.