Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve diagnostics of Controllers, Hardware Components and Controller Manager #1764

Merged
merged 4 commits into from
Oct 9, 2024

Conversation

saikishor
Copy link
Member

This PR in general aims to improve the diagnostics of the ros2_control

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 73.52941% with 9 lines in your changes missing coverage. Please review.

Project coverage is 86.72%. Comparing base (b2794d0) to head (9b65621).

Files with missing lines Patch % Lines
controller_manager/src/controller_manager.cpp 73.52% 4 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1764      +/-   ##
==========================================
- Coverage   86.76%   86.72%   -0.05%     
==========================================
  Files         116      116              
  Lines       10718    10749      +31     
  Branches      981      989       +8     
==========================================
+ Hits         9300     9322      +22     
- Misses       1064     1068       +4     
- Partials      354      359       +5     
Flag Coverage Δ
unittests 86.72% <73.52%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../include/controller_manager/controller_manager.hpp 100.00% <ø> (ø)
controller_manager/src/controller_manager.cpp 77.06% <73.52%> (-0.17%) ⬇️

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

controller_manager/src/controller_manager.cpp Outdated Show resolved Hide resolved
destogl
destogl previously approved these changes Sep 25, 2024
Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change, otherwise good.

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bmagyar bmagyar merged commit 55eb3a8 into ros-controls:master Oct 9, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants