Merge current master into cm-remove-robot-description #1608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs. (ros-controls#1355) Co-authored-by: Sai Kishor Kothakota <[email protected]>
…escription` and update docs regarding this (ros-controls#1410) * Use `robot_description` instead of `~/robot_description` topic Using robot_description by default instead will work for most people out of the box while also working correctly with different descriptions in different namespaces when using remaps. Nowadays, the parameter is deprecated and will be removed. --------- Co-authored-by: Sai Kishor Kothakota <[email protected]> Co-authored-by: Dr. Denis <[email protected]>
…controls#1357) * Remove deprecated parameters and warnings about getting robot descriptions from the parameter. --------- Co-authored-by: Felix Exner (fexner) <[email protected]>
…bugging easier. (ros-controls#1580) * Small improvements to the error output in component parser to make debugging easier. * Correct formatting.
…d add error handling there to avoid stack crashing when error happens. (ros-controls#1354)
Co-authored-by: christophfroehlich <[email protected]>
…robot_description through topic (ros-controls#1451)
…os-controls#971) --------- Co-authored-by: AndyZe <[email protected]> Co-authored-by: bijoua <[email protected]> Co-authored-by: Guillaume Walck <[email protected]> Co-authored-by: Christoph Fröhlich <[email protected]> Co-authored-by: Sai Kishor Kothakota <[email protected]> Co-authored-by: Manuel M <[email protected]>
…rs (ros-controls#1021) --------- Co-authored-by: Bence Magyar <[email protected]> Co-authored-by: Dr. Denis <[email protected]> Co-authored-by: Christoph Fröhlich <[email protected]>
…HardwareComponent (ros-controls#1585) * Add the `init` API in the hardware interfaces to parse the logging and clock interfaces * Change RCUTILS logging to RCLCPP logging * rename `ResourceManager` to `resource_manager` in the logger * support for the default `rm_logger_` if none provided --------- Co-authored-by: Dr. Denis <[email protected]>
…cription-from-param
github-actions
bot
requested review from
bijoua29,
bmagyar,
destogl,
jaron-l,
livanov93,
mcbed and
saikishor
|
@fmauch, all pull requests must be targeted towards the |
christophfroehlich
merged commit e61a17f
into
ros-controls:cm-remove-robot-description-from-param
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1358 has been hanging there for a while now. This PR merges the current master to resolve conflicts. With the result we should be able to review #1358 properly.