Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add find_package for ament_cmake_gen_version_h #1534

Merged
merged 2 commits into from
May 11, 2024

Conversation

christophfroehlich
Copy link
Contributor

We have the joint_limits package failing on the build farm since #1449

08:25:10 CMake Error at cmake_install.cmake:145 (file):
08:25:10   file INSTALL cannot find
08:25:10   "/tmp/binarydeb/ros-rolling-joint-limits-4.10.0/.obj-x86_64-linux-gnu/ament_generate_version_header/joint_limits/joint_limits/version.h":
08:25:10   No such file or directory.

@saikishor and myself tried to find the root cause, and why joint_limits is the only package failing.

We now think this might be due to a missing find_package(ament_cmake_gen_version_h REQUIRED). The other packages include rclcpp, which includes tracetools, which has this find_package and might export this dependency "upstream". This is missing in joint_limits.

Related to ament/ament_cmake#525

Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.66%. Comparing base (edfb971) to head (132acab).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1534      +/-   ##
==========================================
+ Coverage   87.65%   87.66%   +0.01%     
==========================================
  Files         102      102              
  Lines        8618     8617       -1     
  Branches      774      774              
==========================================
  Hits         7554     7554              
+ Misses        788      787       -1     
  Partials      276      276              
Flag Coverage Δ
unittests 87.66% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding!

@clalancette
Copy link
Contributor

See ament/ament_cmake#525 (comment) ; this is actually a bug in ament_generate_version_header. My best suggestion for right now is to remove it from this INTERFACE only package until we get that PR merged and released.

@bmagyar bmagyar merged commit ac5dfb4 into master May 11, 2024
16 of 19 checks passed
@bmagyar bmagyar deleted the find_package_ament_cmake branch May 11, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants