Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Random123 instead of Isaac64, ACG and MLCG #2674

Closed
wants to merge 14 commits into from

Conversation

alkino
Copy link
Member

@alkino alkino commented Jan 18, 2024

Remove usage of:

  • Isaac64
  • ACG
  • MLCG

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: Patch coverage is 62.79070% with 16 lines in your changes missing coverage. Please review.

Project coverage is 66.26%. Comparing base (17bd2c8) to head (76d3d1d).
Report is 246 commits behind head on master.

Files with missing lines Patch % Lines
src/ivoc/ivocrand.cpp 62.50% 15 Missing ⚠️
src/nrniv/multisend_setup.cpp 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2674      +/-   ##
==========================================
+ Coverage   66.23%   66.26%   +0.02%     
==========================================
  Files         559      557       -2     
  Lines      104008   103950      -58     
==========================================
- Hits        68890    68881       -9     
+ Misses      35118    35069      -49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

This comment has been minimized.

Copy link

✔️ af57bd1 -> Azure artifacts URL

Copy link

✔️ a5507cc -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

@alkino alkino marked this pull request as draft January 22, 2024 21:19
@bbpbuildbot

This comment has been minimized.

@bbpbuildbot

This comment has been minimized.

@alkino alkino changed the title Move all RNG to src/gnu Use Random123 as unique RNG Jan 31, 2024
@alkino alkino marked this pull request as ready for review January 31, 2024 17:55
@bbpbuildbot

This comment has been minimized.

@pramodk
Copy link
Member

pramodk commented Feb 1, 2024

@alkino : I was reviewing Michael's comment during last meeting (recording here @ time 17:20). He confirmed removal of 1) Isaac64 2) ACG 3) MLCG.

So I was thinking the steps could be following:

  • A PR to remove 1) Isaac64 2) ACG 3) MLCG
    • launch the modelDB CI
    • hopefully there won't be many neuron tests or ModelDB models CI failures as these are not used much (?)
    • if any tests are using those then fix the tests to use Random123.
    • Michael will look into ModelDB CI failures, convert them to Random123 and validate results
  • Along with the above PR, create a PR to release/8.2 branch adding warning if user try to instantiation any of the above 3
  • Create separate PR for updating MCellRan4 to use Random123 underneath (i.e. we keep API)
    • same CI checks as above.
    • As MCellRan4 might have been used at more places, there might be a bit more work. But Michael has offered help to validate & convert models with Random123.

So considering the above, I am wondering if it is possible to split the removal of the above 3 RNs in one PR and MCellRan4 into another one. My "hope" is that the removal of the above 3 should be straightforward / less or no CI failures and hence can be merged faster.

@ohm314 ohm314 changed the title Use Random123 as unique RNG Use Random123 as the only RNG Feb 1, 2024
@alkino alkino changed the title Use Random123 as the only RNG Use Random123 instead of Isaac64, ACG and MLCG Feb 1, 2024
@bbpbuildbot

This comment has been minimized.

@bbpbuildbot

This comment has been minimized.

Copy link

✔️ efbf7c5 -> Azure artifacts URL

Copy link
Contributor

github-actions bot commented Feb 1, 2024

NEURON ModelDB CI: launching for efbf7c5 via its drop url

src/gnu/Rand.cpp Show resolved Hide resolved
@bbpbuildbot

This comment has been minimized.

Copy link

✔️ f48accb -> Azure artifacts URL

Copy link

sonarcloud bot commented Feb 9, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

✔️ 76d3d1d -> Azure artifacts URL

This was referenced Nov 9, 2024
@alkino
Copy link
Member Author

alkino commented Nov 9, 2024

Replaced by #3188, #3189 and #3190

@alkino alkino closed this Nov 9, 2024
@alkino alkino deleted the cornu/move_allrng_to_gnu branch November 9, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants