Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Isaac64 by Random123 #3188

Merged
merged 2 commits into from
Nov 9, 2024
Merged

Replace Isaac64 by Random123 #3188

merged 2 commits into from
Nov 9, 2024

Conversation

alkino
Copy link
Member

@alkino alkino commented Nov 9, 2024

This has already been accepted by @nrnhines a long time ago (#2674).
This is only a split of the old PR.

Copy link

✔️ da8340b -> Azure artifacts URL

Copy link

codecov bot commented Nov 9, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.06%. Comparing base (a5d0015) to head (c55f95b).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/nrniv/multisend_setup.cpp 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3188   +/-   ##
=======================================
  Coverage   67.05%   67.06%           
=======================================
  Files         571      570    -1     
  Lines      111256   111232   -24     
=======================================
- Hits        74604    74599    -5     
+ Misses      36652    36633   -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

This comment has been minimized.

Copy link
Member

@nrnhines nrnhines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to add or augment a multisend test that covers the line in multisend_setup.cpp

src/nrniv/multisend_setup.cpp Show resolved Hide resolved
@nrnhines nrnhines enabled auto-merge (squash) November 9, 2024 13:59
Copy link

sonarcloud bot commented Nov 9, 2024

Copy link

✔️ c55f95b -> Azure artifacts URL

@nrnhines nrnhines merged commit 625f3d1 into master Nov 9, 2024
36 checks passed
@nrnhines nrnhines deleted the cornu/isaac64 branch November 9, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants