#303: Reset cookies in site manager

[rafeerahman]

Before submitting your pull request

• I agree to license my code under the MPL 2.0 license.
• I rebased my work on top of the main branch.
• I ran npm test and all tests passed.
• I added test coverages if relevant.

Description

Allows users to reset cookies for a site in the containers "Site manager"

Type of change

Select all that apply.

• Bug fix
• New feature
• Major change (fix or feature that would cause existing functionality to work differently than in the current version)

How to test:

Site manager cookie clearing:

1. cd into src/_locales and pull the latest changes. Then checkout the branch titled clear-storage-confirmation-strings
2. Go to relay.firefox.com and click the "Always open in container" icon then select your Personal container.
3. Sign in to your Relay account.
4. Open the MAC popup.
5. Click the right arrow on the "Personal" container, then click "Manage this container"
6. Click on "Manage site list"
7. Verify that you can hover over and see tooltips for the delete and refresh icons.
8. Click on the refresh icon.
9. Verify that the permissions popup shows if you don't have "Clear recent browsing history, cookies, and related data" toggled already, and click "Allow".
10. Go back to the refresh icon, and click it to clear cookies.
11. Verify a popup notifcation confirming that cookies have been cleared is shown.
12. Open relay.firefox.com again and check that you are not signed in.

Container storage clearing:

12. Disable "Clear recent browsing history, cookies, and related data" permissions in the extension manager.
13. Open one a site of your choice in a container.
14. Open that container's menu by clicking the "right arrow" on it in the popup.
15. Click "clear storage and cookies".
16. Verify that the permission pop up shows, and click "Allow".
17. Go Back to the "Clear storage and cookies" option and click it.
18. Verify that the confirmation page shows up.
19. Verify that clicking "OK" clears cookies and localstorage.
20. Verify that this pages "Cancel" and "Back" options work.

Tag issues related to this pull request:

• Reset cache/cookies of containers without deleting them #303

L10n: mozilla-l10n/multi-account-containers-l10n#28
L10n: mozilla-l10n/multi-account-containers-l10n#29

[groovecoder]

Thanks @rafeerahman this is a great feature. After re-reading the issue and comments, this doesn't quite seem to implement what most people are asking for.

It seems most people want a way to clear all the browsing data (cookies, cache, and local storage) for the entire container. It seems @dannycolin's PR is quite close to that already.

@dannycolin: Can you say more about why your PR is WIP? It seems ready to merge to me.

@rafeerahman: If @dannycolin's PR is ready, I think we should combine both of these PRs together. I think they both add a very nice features for reseting container data without having to destroy the container. If anything, I think you're change is even more advanced and sophisticated!

[dannycolin]

@dannycolin: Can you say more about why your PR is WIP? It seems ready to merge to me.

There's a limitation around the cache removal. According to the documentation on MDN, browsingData.removeCache() will ignore the browsingData.RemovalOptions object and so you cannot limit the removal to a specific container.

https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/browsingData/removeCache

@rafeerahman: If @dannycolin's PR is ready, I think we should combine both of these PRs together. I think they both add a very nice features for reseting container data without having to destroy the container. If anything, I think you're change is even more advanced and sophisticated!

I Agree. The ability to remove per domain is great for a poweruser tool but it does increase the complexity of the UX/UI. I don't have a strong opinion on implementing it or not but I simply wanted to point it out since our frontend code is in need of some TLC :).

[chetan-reddy]

@dannycolin: Can you say more about why your PR is WIP? It seems ready to merge to me.

There's a limitation around the cache removal. According to the documentation on MDN, browsingData.removeCache() will ignore the browsingData.RemovalOptions object and so you cannot limit the removal to a specific container.

https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/browsingData/removeCache

@dannycolin I apologize if I'm wrong, but would you be able to use browsingData.remove() which does support limiting by RemovalOptions.cookieStoreId and browsingData.DataTypeSet ?

https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/browsingData/remove

I inferred that browsingData.remove might work from this comment -> https://bugzilla.mozilla.org/show_bug.cgi?id=1353726#c13

[dannycolin]

@dannycolin I apologize if I'm wrong, but would you be able to use browsingData.remove() which does support limiting by RemovalOptions.cookieStoreId and browsingData.DataTypeSet ?

I inferred that browsingData.remove might work from this comment -> https://bugzilla.mozilla.org/show_bug.cgi?id=1353726#c13

@chetan-reddy Excerpt from the webextension API documentation itself:

With browsingData.removeCache() note that although this function can take a browsingData.RemovalOptions object, it will be ignored. The entire cache is always cleared when using this function.

[jkuj6]

I came here from cookie autodelete, having removed it because its no longer maintained.
I was about to request a feature in here regarding removing or "emptying out" a container's entire cookies and cache by the push of a button. Is this whats being implemented here?
Maybe when long-pressing the "open a new tab +" next to each container there can be a Brush Cleaning icon button to clear the entire container and have a message popup telling you the container's data (without closing any tabs) has been cleared?

thanks in advance

[rafeerahman]

I came here from cookie autodelete, having removed it because its no longer maintained. I was about to request a feature in here regarding removing or "emptying out" a container's entire cookies and cache by the push of a button. Is this whats being implemented here? Maybe when long-pressing the "open a new tab +" next to each container there can be a Brush Cleaning icon button to clear the entire container and have a message popup telling you the container's data (without closing any tabs) has been cleared?

Yes thats whats being implemented. Cool idea, we can definitely look into adding it in that menu as well.

[groovecoder]

change (blocking): I'm afraid that clearing all site data is destructive enough that we should add a confirmation dialog to this? Or change the UI so that it's harder to accidentally do it.

The clear cookies UI isn't too bad ... the button is next to another data-destroying button so it's less likely that someone would accidentally click it. But it's still possible, so could we move it further away from the other button?

More concerning is how close the "Clear storage and cookies" item is to "Always open site in Container" item - which are 2 very different intentions.

I'm asking @maxxcrawford if there's a Firefox design guide to help us here.

[dannycolin]

@groovecoder For the confirmation dialog, I think we should use the same pattern that we use when a user deletes a container.

[andsofine]

Sorry, I don't know if this is the right place, but I was wondering if these changes will be implemented in the browser itself?

Cause cookies can be deleted through the lock icon (to the left of the address bar) and also in the settings.

I was clearing cookies through the lock icon for a while until I realized that it deletes cookies for all containers. It wasn't very obvious

[groovecoder]

Sorry, I don't know if this is the right place, but I was wondering if these changes will be implemented in the browser itself?

No. You would need to file a new bugzilla bug in the Data Sanitization component change the behavior of the lock icon item.

[groovecoder]

suggestion (non-blocking): This is an existing bug, so it shouldn't block this feature. It's just more obvious with this new feature.

For some reason, the .scrollable block-size: 100% directive causes the site assignment panel to ALWAYS have a scrollbar even when its not needed?

And the trash can icon is covered up by the scrollbar.

I couldn't find an existing bug for this, so I filed a new one here: #2662

[andsofine]

Sorry, I don't know if this is the right place, but I was wondering if these changes will be implemented in the browser itself?

No. You would need to file a new bugzilla bug in the Data Sanitization component change the behavior of the lock icon item.

It says that my email address will be public, is there any other issue tracker?
Or maybe can you fill it?

[colans]

@andsofine : Use an email alias. There are various options, but I like https://proton.me/pass/aliases