Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strings for a new confirmation panel for container storage clearing. #29

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

rafeerahman
Copy link
Contributor

This PR adds a couple strings for the confirmation panel when clearing a containers cookies and storage.

Reference PR: mozilla/multi-account-containers#2654

"message": "Clear Container Storage"
},
"clearContainerStorageConfirmation": {
"message": "Are you sure you want to clear cookies and storage for this Container?"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This uses the same pattern as previous strings, but it doesn't make a lot of sense for container to be uppercase. It would be worth discussing with content about it.

@flodolo flodolo merged commit 6e984ec into main Aug 28, 2024
2 checks passed
@flodolo flodolo deleted the clear-storage-confirmation-strings branch August 28, 2024 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants