Strings for new container storage clear feature #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
From the log it looks like you closed it before force-pushing? The latter never closes an open PR. |
flodolo
requested changes
Aug 20, 2024
en/messages.json
Outdated
| } | ||
| }, | ||
| "storageWasClearedConfirmation": { | ||
| "message": "$containerName$'s storage and cookies were cleared.", |
There was a problem hiding this comment.
Suggested change
| "message": "$containerName$'s storage and cookies were cleared.", | |
| "message": "$containerName$’s storage and cookies were cleared.", |
en/messages.json
Outdated
| }, | ||
| "storageWasClearedConfirmation": { | ||
| "message": "$containerName$'s storage and cookies were cleared.", | ||
| "description": "Error message if cookies could not be cleared in the site manager", |
There was a problem hiding this comment.
This comment doesn't match the string
Hm I'm not entirely sure what happened, I don't recall clicking close but maybe I misclicked somewhere. |
flodolo
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated terminology and strings for mozilla/multi-account-containers#2654.
(I think the previous PR closed because I force-pushed?)