Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strings for new container storage clear feature #28

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Strings for new container storage clear feature #28

merged 1 commit into from
Aug 20, 2024

Conversation

rafeerahman
Copy link
Contributor

Updated terminology and strings for mozilla/multi-account-containers#2654.

(I think the previous PR closed because I force-pushed?)

@flodolo
Copy link
Contributor

flodolo commented Aug 20, 2024

(I think the previous PR closed because I force-pushed?)

#27

From the log it looks like you closed it before force-pushing? The latter never closes an open PR.

Copy link
Contributor

@flodolo flodolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nits to fix, but otherwise it looks good.

en/messages.json Outdated
}
},
"storageWasClearedConfirmation": {
"message": "$containerName$'s storage and cookies were cleared.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"message": "$containerName$'s storage and cookies were cleared.",
"message": "$containerName$s storage and cookies were cleared.",

en/messages.json Outdated
},
"storageWasClearedConfirmation": {
"message": "$containerName$'s storage and cookies were cleared.",
"description": "Error message if cookies could not be cleared in the site manager",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment doesn't match the string

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed now

@rafeerahman
Copy link
Contributor Author

(I think the previous PR closed because I force-pushed?)

#27

From the log it looks like you closed it before force-pushing? The latter never closes an open PR.

Hm I'm not entirely sure what happened, I don't recall clicking close but maybe I misclicked somewhere.

@flodolo flodolo merged commit c41dc1e into main Aug 20, 2024
2 checks passed
@flodolo flodolo deleted the feat-#303 branch August 20, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants