[WIP] Switch to poetry for package management #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added wheel to the dev requirements.txt to avoid the missing Cython error that occurs when building from source [1]. This also removed the need for cython as an extra dependency of HACK. Numpy is moved up in the dependency list so that it is present before scikit-learn is attempted to be installed, which will fail otherwise. Postgresql isn't specifically installed since it is included in the GitHub Action VM. [1]: scikit-learn/scikit-learn#19068
This also updates the dependencies to the latest compatible versions and fixes all the lint errors that result.
This way, the CLI scripts are automatically installed when running `poetry install` and are available for use as described in the README.
|
I'm starting another full run of the transistor dataset now to verify this switch doesn't break anything. |
Snorkel is restricting the networkx dependency to <2.4, which doesn't support Python 3.9. Consequently, we can't use 3.9 either.
|
Here is one e2e log with this poetry setup: The intermediate numbers are slightly different, but the end results are very similar. I'll run the opamps and circular connectors next. |
|
Here's an e2e log for opamps: This shows a significant regression on the gain relation that should be looked at more closely. |
|
Here's an e2e log for circular connectors: 2021-04-21_circular-connectors.log This also shows a significant regression in F1 (~5 pts) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Poetry has gained a lot of popularity, and one key feature is the lockfile. If we include that we can be more effectively capture the exact versions and dependencies needed to run the pipeline.
Before this is merged: