Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(setup.py): enforce Snorkel is before v0.9.7 #66

Merged
merged 1 commit into from
Mar 22, 2021
Merged

Conversation

nicholaschiang
Copy link
Collaborator

Snorkel v0.9.7 introduced some breaking dependency changes that this HACK repository isn't compatible with:

ERROR: snorkel 0.9.7 has requirement numpy<1.20.0,>=1.16.5, but you'll have numpy 1.20.1 which is incompatible.
ERROR: snorkel 0.9.7 has requirement pandas<2.0.0,>=1.0.0, but you'll have pandas 0.25.3 which is incompatible.

See: https://github.com/snorkel-team/snorkel/releases/tag/v0.9.7

Snorkel v0.9.7 introduced some breaking dependency changes that this
HACK repository isn't compatible with.

See: https://github.com/snorkel-team/snorkel/releases/tag/v0.9.7
@lukehsiao
Copy link
Owner

Should we hold snorkel back, or just go to snorkel 0.9.7 and update numpy and pandas in setup.py?

@nicholaschiang
Copy link
Collaborator Author

If you update numpy and pandas, doesn't that mean you should re-run everything to make sure it still works? IMO it's safer just to use the old versions unless it really matters.

@nicholaschiang
Copy link
Collaborator Author

Updating pandas would mean a major version change from pandas<0.26.0,>=0.25.0 to pandas<2.0.0,>=1.0.0 as required by Snorkel v0.9.7.

@lukehsiao
Copy link
Owner

IMO it's safer just to use the old versions unless it really matters.

Hard to argue with that. I can confirm I'm not seeing any errors with a fresh Python3 venv on 20.04. Did you test it as well?

(Maybe I'll try and get some GitHub Actions hooked up to run make dev at least).

@lukehsiao lukehsiao merged commit fc71f14 into master Mar 22, 2021
@lukehsiao lukehsiao deleted the snorkel-dep branch March 22, 2021 20:21
@nicholaschiang
Copy link
Collaborator Author

Yup, I tested and it works fine with this constraint.

@nicholaschiang
Copy link
Collaborator Author

And yeah, a CRON job on GitHub actions every couple of weeks just to ensure that the deps don't break will probs be good (seeing how flaky pip can be).

@lukehsiao
Copy link
Owner

I'm investigating switching from pip to poetry so we have a real lockfile in #67. I'm re-running some stuff first, but I expect the switch shouldn't cause any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants