Pass client identity config with every API request #593
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to pass config identifying tool/integration using library. The config is then send as
User-Agent
header with every API request. Needed for https://github.com/kubeshop/monokle-saas/issues/1904.This follows standard format for
User-Agent
headers, for reference see:In short:
which in our case could be (the simplest version):
Then
comment
is additional data in()
. Browsers put there OS info or similar usually, so we will have it there too:This is also important since
ua-parser-js
library is used on the BE which can parse such OS info properly and will send it as separate payload parameter (see here).The
comment
part can also contain other arbitrary data, common format iskey=value; key=value; ...
and this allows us to send any additional data we need, e.g.:Changes
Fixes
Checklist