Add client data to synchronizer instances #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f1ames
force-pushed
the
f1ames/fix/client-identity
branch
from
ce22cee
to
fdaa8cb
Compare
WitoDelnat
approved these changes
Jan 2, 2024
WitoDelnat
reviewed
Jan 2, 2024
src/client-config.ts
Outdated
| version: pkg.version, | ||
| os: `${type()} ${release()}`, | ||
| additionalData: { | ||
| machineId: env.machineId, |
There was a problem hiding this comment.
For privacy concerns, maybe we should only add this when analytics are enabled?
There was a problem hiding this comment.
Makes sense, especially that without telemetry we won't get any other data to connect with this one by machineId.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds client data to synchronizer instances. Part of https://github.com/kubeshop/monokle-saas/issues/1904.
Requires kubeshop/monokle-core#593.
Changes
Fixes
Checklist