-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add client data to synchronizer instances #4206
Conversation
version: app.getVersion(), | ||
os: `${type()} ${release()}`, | ||
additionalData: { | ||
machineId: machineIdSync(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe for privacy purposes I'd only pass machine id when analytics are enabled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 44c35df.
This still requires Code Owner review (or an Admin 😃) to be merged. cc @WitoDelnat @olensmar |
This PR adds client data to synchronizer instances. Part of https://github.com/kubeshop/monokle-saas/issues/1904.
Requires kubeshop/monokle-core#593.
Changes
Fixes
How to test it
User-Agent
send correctly.Screenshots
Checklist