Migrate Elyra extensions to support JupyterLab 4.x #3201

lresende · 2023-12-18T18:08:57Z

What changes were proposed in this pull request?

Migrate Elyra extensions to support JupyterLab 4.x

How was this pull request tested?

Building and running on JupyterLab 4.x

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

kevin-bates

I'm assuming the build failures are a temporary hurdle. Thanks for dealing with the @lresende!

Signed-off-by: Luciano Resende <[email protected]>

lresende · 2023-12-20T04:29:02Z

I have made some progress here, but I would appreciate if I could get some help on the UI pieces, in particular on UI-components... @marthacryan @karlaspuldaro @ajbozarth and others feel free to send prs to this branch as time permits... I completely understand if you are not able to.

Signed-off-by: Luciano Resende <[email protected]>

karlaspuldaro · 2024-02-09T17:47:03Z

.github/workflows/build.yml

@@ -41,7 +41,12 @@ jobs:
            /home/runner/.cache/Cypress
          key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
      - name: Install
-        run: yarn install --frozen-lockfile && tsc -v
+        run: |
+          corepack prepare [email protected] --activate


This line is causing build failure, maybe it's best to use a stable version of yarn

hadesto · 2024-06-07T14:49:34Z

hello! is this pull request still being worked on? it would be amazing to have support for JL4 now that JL3 has an official sunset date. Is there any support required from the community? Thank you!

lresende · 2024-06-08T08:45:28Z

There is a pr against this pr, let me merge that over the weekend and then others can jump in to help finish any remaining items

hadesto · 2024-06-12T16:52:47Z

thanks for the quick response!

ederign · 2024-08-14T22:43:16Z

hi @lresende, thank you so much for this work! Where are these 'remaining items' located? I would love to figure out ways to help! (at least testing it)

harshad16 · 2024-08-19T14:46:06Z

thank you so much for this work! Where are these 'remaining items' located? I would love to figure out ways to help! (at least testing it)

@ederign they are opened as PR to the branch, here: lresende#1

Updated LauncherModel to accommodate changes in @lumino/algorithm. Resolved build errors related to missing properties and import issues.

Resolved type errors related to missing children property in Dropzone.tsx, ExpandableComponent.tsx, and ExpandableErrorDialog.tsx. Fixed import issues in FormEditor.tsx by addressing missing members and correcting import statements. Improved TypeScript type inference and resolved implicit 'any' types in parameters and binding elements in JSONComponent.tsx.

This reverts commit 0f9df32.

Updated r-editor to be compatible with Jupyter Lab 4.x. Similar changes to scala-editor.

Because involved react component and does not directly conform to the IFormRenderer interface use assertion to satisfy the type requirements of the addRenderer method. Also improve types definition for imported component in ui-components. Now able to build metadata.

I have resolved most of the errors currently in the pipeline editor however I got stuck attempting to fix the error: error TS2322: Type '{ children: Element[]; theme: any; }' is not assignable to type 'IntrinsicAttributes & { theme: DeepPartial<Theme>; }'. Property 'children' does not exist on type 'IntrinsicAttributes & { theme: DeepPartial<Theme>; }'.

Updated CodeSnippetDisplay class to extend MetadataDisplay with the correct props type Replace usage of deprecated ContentFactory, but still exist issue when missing documentation.

tried to fix the first code cell creation error, but still have issue when inserting cell to notebook widget

Just figured out how to properly add codecell.

Fixed some method calling base on documentation.

Resolved final error in pipeline editor. Now it's able to build.

- .value.text does not work for updating the content of Cell, Replaced with .setSource. - Refresh no longer exists, replaced with redo. Can't find any documentation about this change. - fixed creation of preview editor

This reverts commit ac10f57.

This reverts commit b2630c7.

This reverts commit 9ab11eb.

trying to adjust workflow build issue

lresende added the status:Work in Progress Development in progress. A PR tagged with this label is not review ready unless stated otherwise. label Dec 18, 2023

lresende requested a review from kevin-bates December 18, 2023 18:08

kevin-bates approved these changes Dec 18, 2023

View reviewed changes

lresende force-pushed the lresende-lab4 branch 2 times, most recently from af4a4de to ab95e71 Compare December 20, 2023 03:52

lresende added 3 commits December 19, 2023 19:53

Update Elyra's version to 4.0.0

b93e553

Signed-off-by: Luciano Resende <[email protected]>

Update 3rd party extensions to Lab4 compatible

0689538

Signed-off-by: Luciano Resende <[email protected]>

Initial JupyterLab 4.0 support

8a44617

Signed-off-by: Luciano Resende <[email protected]>

lresende force-pushed the lresende-lab4 branch 6 times, most recently from a5b1686 to 6410a77 Compare December 20, 2023 04:25

lresende force-pushed the lresende-lab4 branch 2 times, most recently from 110767d to 7567988 Compare December 20, 2023 04:32

lresende added 2 commits January 5, 2024 10:05

Update build to use yarn 3.5

03b134c

Signed-off-by: Luciano Resende <[email protected]>

wip - code changes to lab4

95332e5

Signed-off-by: Luciano Resende <[email protected]>

lresende force-pushed the lresende-lab4 branch from 7567988 to 95332e5 Compare January 5, 2024 18:06

krassowski mentioned this pull request Jan 22, 2024

Extension Compatibility with JupyterLab 4.0 jupyterlab/jupyterlab#14590

Open

karlaspuldaro reviewed Feb 9, 2024

View reviewed changes

paulovmr mentioned this pull request Aug 21, 2024

[WIP] JupyterLab 4.x upgrade opendatahub-io/elyra#25

Merged

xinchaochen8 added 2 commits September 1, 2024 20:53

Fixed issues with yarn module and build errors.

1d2921d

Updated LauncherModel to accommodate changes in @lumino/algorithm. Resolved build errors related to missing properties and import issues.

xinchaochen8 and others added 30 commits September 1, 2024 20:53

Revert "Updated yarn.lock for @rjsf/validator-ajv8"

cb219fd

This reverts commit 0f9df32.

r-editor update

666ed15

Updated r-editor to be compatible with Jupyter Lab 4.x. Similar changes to scala-editor.

Refactored code snippet insertion for JupyterLab 4.x compatibility

5ba3399

Updated CodeSnippetDisplay class to extend MetadataDisplay with the correct props type Replace usage of deprecated ContentFactory, but still exist issue when missing documentation.

Attempt to fix cell creation

b6337d0

tried to fix the first code cell creation error, but still have issue when inserting cell to notebook widget

Update CodeSnippetWidget.tsx

d00506b

Just figured out how to properly add codecell.

Update CodeSnippetWidget.tsx

f235037

Fixed some method calling base on documentation.

PipelineEditorFixed

57a506b

Resolved final error in pipeline editor. Now it's able to build.

updated code snippet display functionality

16f06f6

- .value.text does not work for updating the content of Cell, Replaced with .setSource. - Refresh no longer exists, replaced with redo. Can't find any documentation about this change. - fixed creation of preview editor

updated naming for interface to match naming conventionn

13a2e50

regex format match

85191c6

Test remove unused

1cd175b

test

8a0ea29

verifying elyra do build

c88adbf

Revert "test"

6255f7a

This reverts commit ac10f57.

test

321179c

reformat some files that cause build to fail

f4ab3d9

Use JupyterLab 4.0

03367bf

Minor dependency updates

a0d82ea

Pin jupyterlab-lsp to 5.0.3 due to lab 4.1 dependencies

61a3e3c

test to resolve yarn failure on github

71dbca6

Update build.yml for GitHub workflow

ba63cdf

Revert "Update build.yml for GitHub workflow"

88de1e7

This reverts commit b2630c7.

Update build.yml for yarn workflow error

7245e13

Revert "Update build.yml for yarn workflow error"

5991055

This reverts commit 9ab11eb.

Update .yarnrc.yml

4b7817d

Update build.yml

abee693

trying to adjust workflow build issue

try latest version

897459e

maybe issue with node version?

c46ec87

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate Elyra extensions to support JupyterLab 4.x #3201

Migrate Elyra extensions to support JupyterLab 4.x #3201

lresende commented Dec 18, 2023 •

edited

Loading

kevin-bates left a comment

lresende commented Dec 20, 2023

karlaspuldaro Feb 9, 2024

hadesto commented Jun 7, 2024

lresende commented Jun 8, 2024

hadesto commented Jun 12, 2024

ederign commented Aug 14, 2024

harshad16 commented Aug 19, 2024

Migrate Elyra extensions to support JupyterLab 4.x #3201

Are you sure you want to change the base?

Migrate Elyra extensions to support JupyterLab 4.x #3201

Conversation

lresende commented Dec 18, 2023 • edited Loading

What changes were proposed in this pull request?

How was this pull request tested?

kevin-bates left a comment

Choose a reason for hiding this comment

lresende commented Dec 20, 2023

karlaspuldaro Feb 9, 2024

Choose a reason for hiding this comment

hadesto commented Jun 7, 2024

lresende commented Jun 8, 2024

hadesto commented Jun 12, 2024

ederign commented Aug 14, 2024

harshad16 commented Aug 19, 2024

lresende commented Dec 18, 2023 •

edited

Loading