Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Elyra extensions to support JupyterLab 4.x #3201

Open
wants to merge 46 commits into
base: main
Choose a base branch
from

Commits on Dec 20, 2023

  1. Update Elyra's version to 4.0.0

    Signed-off-by: Luciano Resende <[email protected]>
    lresende committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    b93e553 View commit details
    Browse the repository at this point in the history
  2. Update 3rd party extensions to Lab4 compatible

    Signed-off-by: Luciano Resende <[email protected]>
    lresende committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    0689538 View commit details
    Browse the repository at this point in the history
  3. Initial JupyterLab 4.0 support

    Signed-off-by: Luciano Resende <[email protected]>
    lresende committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    8a44617 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2024

  1. Update build to use yarn 3.5

    Signed-off-by: Luciano Resende <[email protected]>
    lresende committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    03b134c View commit details
    Browse the repository at this point in the history
  2. wip - code changes to lab4

    Signed-off-by: Luciano Resende <[email protected]>
    lresende committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    95332e5 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2024

  1. Fixed issues with yarn module and build errors.

    Updated LauncherModel to accommodate changes in @lumino/algorithm. Resolved build errors related to missing properties and import issues.
    xinchaochen8 authored and lresende committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    1d2921d View commit details
    Browse the repository at this point in the history
  2. Type and import errors fixed in components.

    Resolved type errors related to missing children property in Dropzone.tsx, ExpandableComponent.tsx, and ExpandableErrorDialog.tsx. Fixed import issues in FormEditor.tsx by addressing missing members and correcting import statements. Improved TypeScript type inference and resolved implicit 'any' types in parameters and binding elements in JSONComponent.tsx.
    xinchaochen8 authored and lresende committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    2896da0 View commit details
    Browse the repository at this point in the history
  3. Fixing compile errors for ui-components

    TypeScript Error: Incompatibility
    Component Structure: Clarification
    Prop Types: Consistency and Definition
    xinchaochen8 authored and lresende committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    c3f6009 View commit details
    Browse the repository at this point in the history
  4. Resolving type errors

    Unable to find the documentation regarding changes that made the types unavailable, and defined new types base on available specifications in 3.6x.
    
    `Property 'IConfig' does not exist on type 'typeof CodeEditor'.ts(2339)`
    `Namespace '.../node_modules/@jupyterlab/codeeditor/lib/editor".CodeEditor' has no exported member 'IConfig'.ts(2694)`
    xinchaochen8 authored and lresende committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    2405e13 View commit details
    Browse the repository at this point in the history
  5. python editor is not able to build

    Note:
    to compile python editor, build script editor first
    xinchaochen8 authored and lresende committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    80a73c4 View commit details
    Browse the repository at this point in the history
  6. Update CodeBlock.tsx

    Updated CodeBlock to uses updated version of CodeEditor.
    Changed the implementation base on the source code for IOptions:
    https://github.com/jupyterlab/jupyterlab/blob/d274f84/packages/codeeditor/src/editor.ts#L553
    xinchaochen8 authored and lresende committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    aa5ab50 View commit details
    Browse the repository at this point in the history
  7. Update Tags.tsx

    fixed type errors for TagsField
    xinchaochen8 authored and lresende committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    c08691b View commit details
    Browse the repository at this point in the history
  8. FormRendererRegistry Changes

    Changed IFormComponentRegistry in metadata and meta-data common to use IFormRendererRegistry for 4.x.
    EdgarAllan-Bro authored and lresende committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    b14dc7c View commit details
    Browse the repository at this point in the history
  9. resolved build error with ui-components

    The fields prop was removed from FieldTemplateProps in a recent update. Resolved the integration by passing a templates object to the fields prop. Also added validator, which is now a required prop for 5.x Form. But still need to work on resolving precise type configurations.
    
    src: https://rjsf-team.github.io/react-jsonschema-form/docs/migration-guides/v5.x%20upgrade%20guide#rjsfcore-breaking-changes
    xinchaochen8 authored and lresende committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    f550613 View commit details
    Browse the repository at this point in the history
  10. Scala editor updated

    Updated Scala editor to be compatible with 4.x. The code used to use IConfig which is no longer in use. But config options is now currently under IOptions. But we need to see if It displays properly on frontend. But the code currently builds.
    EdgarAllan-Bro authored and lresende committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    79ee2e8 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    89d0502 View commit details
    Browse the repository at this point in the history
  12. Revert "Updated yarn.lock for @rjsf/validator-ajv8"

    This reverts commit 0f9df32.
    xinchaochen8 authored and lresende committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    cb219fd View commit details
    Browse the repository at this point in the history
  13. r-editor update

    Updated r-editor to be compatible with Jupyter Lab 4.x. Similar changes to scala-editor.
    EdgarAllan-Bro authored and lresende committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    666ed15 View commit details
    Browse the repository at this point in the history
  14. The fixing method componentRegistry.addRenderer

    Because involved react component and does not directly conform to the IFormRenderer interface use assertion to satisfy the type requirements of the addRenderer method. Also improve types definition for imported component in ui-components. Now able to build metadata.
    xinchaochen8 authored and lresende committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    6be4527 View commit details
    Browse the repository at this point in the history
  15. Pipeline editor nearly fixed

    I have resolved most of the errors currently in the pipeline editor however I got stuck attempting to fix the error:  error TS2322: Type '{ children: Element[]; theme: any; }' is not assignable to type 'IntrinsicAttributes & { theme: DeepPartial<Theme>; }'.
      Property 'children' does not exist on type 'IntrinsicAttributes & { theme: DeepPartial<Theme>; }'.
    EdgarAllan-Bro authored and lresende committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    98a73d8 View commit details
    Browse the repository at this point in the history
  16. Refactored code snippet insertion for JupyterLab 4.x compatibility

    Updated CodeSnippetDisplay class to extend MetadataDisplay with the correct props type
    Replace usage of deprecated ContentFactory, but still exist issue when missing documentation.
    xinchaochen8 authored and lresende committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    5ba3399 View commit details
    Browse the repository at this point in the history
  17. Attempt to fix cell creation

    tried to fix the first code cell creation error, but still have issue when inserting cell to notebook widget
    xinchaochen8 authored and lresende committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    b6337d0 View commit details
    Browse the repository at this point in the history
  18. Update CodeSnippetWidget.tsx

    Just figured out how to properly add codecell.
    xinchaochen8 authored and lresende committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    d00506b View commit details
    Browse the repository at this point in the history
  19. Update CodeSnippetWidget.tsx

    Fixed some method calling base on documentation.
    xinchaochen8 authored and lresende committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    f235037 View commit details
    Browse the repository at this point in the history
  20. PipelineEditorFixed

    Resolved final error in pipeline editor. Now it's able to build.
    EdgarAllan-Bro authored and lresende committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    57a506b View commit details
    Browse the repository at this point in the history
  21. updated code snippet display functionality

    - .value.text does not work for updating the content of Cell, Replaced with .setSource.
    - Refresh no longer exists, replaced with redo. Can't find any documentation about this change.
    - fixed creation of preview editor
    xinchaochen8 authored and lresende committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    16f06f6 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    13a2e50 View commit details
    Browse the repository at this point in the history
  23. regex format match

    EdgarAllan-Bro authored and lresende committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    85191c6 View commit details
    Browse the repository at this point in the history
  24. Test remove unused

    EdgarAllan-Bro authored and lresende committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    1cd175b View commit details
    Browse the repository at this point in the history
  25. test

    EdgarAllan-Bro authored and lresende committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    8a0ea29 View commit details
    Browse the repository at this point in the history
  26. verifying elyra do build

    xinchaochen8 authored and lresende committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    c88adbf View commit details
    Browse the repository at this point in the history
  27. Revert "test"

    This reverts commit ac10f57.
    EdgarAllan-Bro authored and lresende committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    6255f7a View commit details
    Browse the repository at this point in the history
  28. test

    EdgarAllan-Bro authored and lresende committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    321179c View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    f4ab3d9 View commit details
    Browse the repository at this point in the history
  30. Use JupyterLab 4.0

    lresende committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    03367bf View commit details
    Browse the repository at this point in the history
  31. Minor dependency updates

    lresende committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    a0d82ea View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    61a3e3c View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    71dbca6 View commit details
    Browse the repository at this point in the history
  34. Configuration menu
    Copy the full SHA
    ba63cdf View commit details
    Browse the repository at this point in the history
  35. Revert "Update build.yml for GitHub workflow"

    This reverts commit b2630c7.
    xinchaochen8 authored and lresende committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    88de1e7 View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    7245e13 View commit details
    Browse the repository at this point in the history
  37. Revert "Update build.yml for yarn workflow error"

    This reverts commit 9ab11eb.
    xinchaochen8 authored and lresende committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    5991055 View commit details
    Browse the repository at this point in the history
  38. Update .yarnrc.yml

    xinchaochen8 authored and lresende committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    4b7817d View commit details
    Browse the repository at this point in the history
  39. Update build.yml

    trying to adjust workflow build issue
    xinchaochen8 authored and lresende committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    abee693 View commit details
    Browse the repository at this point in the history
  40. try latest version

    xinchaochen8 authored and lresende committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    897459e View commit details
    Browse the repository at this point in the history
  41. maybe issue with node version?

    xinchaochen8 authored and lresende committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    c46ec87 View commit details
    Browse the repository at this point in the history