[WIP] JupyterLab 4.x upgrade #25

paulovmr · 2024-08-21T18:35:27Z

What changes were proposed in this pull request?

This PR is based on the Elyra community effort (elyra-ai#3201 and lresende#1) to migrate Elyra extensions to support JupyterLab 4.x, with the addition of more changes, such as:

Removed trailing commas to facilitate the diff visualization
Removed fixed Yarn path
Removed duplicated files
[...] WIP to be continued...

How was this pull request tested?

This is a work in progress.

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Signed-off-by: Luciano Resende <[email protected]>

Updated LauncherModel to accommodate changes in @lumino/algorithm. Resolved build errors related to missing properties and import issues.

Resolved type errors related to missing children property in Dropzone.tsx, ExpandableComponent.tsx, and ExpandableErrorDialog.tsx. Fixed import issues in FormEditor.tsx by addressing missing members and correcting import statements. Improved TypeScript type inference and resolved implicit 'any' types in parameters and binding elements in JSONComponent.tsx.

TypeScript Error: Incompatibility Component Structure: Clarification Prop Types: Consistency and Definition

Unable to find the documentation regarding changes that made the types unavailable, and defined new types base on available specifications in 3.6x. `Property 'IConfig' does not exist on type 'typeof CodeEditor'.ts(2339)` `Namespace '.../node_modules/@jupyterlab/codeeditor/lib/editor".CodeEditor' has no exported member 'IConfig'.ts(2694)`

Note: to compile python editor, build script editor first

Updated CodeBlock to uses updated version of CodeEditor. Changed the implementation base on the source code for IOptions: https://github.com/jupyterlab/jupyterlab/blob/d274f84/packages/codeeditor/src/editor.ts#L553

fixed type errors for TagsField

Changed IFormComponentRegistry in metadata and meta-data common to use IFormRendererRegistry for 4.x.

Updated Scala editor to be compatible with 4.x. The code used to use IConfig which is no longer in use. But config options is now currently under IOptions. But we need to see if It displays properly on frontend. But the code currently builds.

The fields prop was removed from FieldTemplateProps in a recent update. Resolved the integration by passing a templates object to the fields prop. Also added validator, which is now a required prop for 5.x Form. But still need to work on resolving precise type configurations. src: https://rjsf-team.github.io/react-jsonschema-form/docs/migration-guides/v5.x%20upgrade%20guide#rjsfcore-breaking-changes

Because involved react component and does not directly conform to the IFormRenderer interface use assertion to satisfy the type requirements of the addRenderer method. Also improve types definition for imported component in ui-components. Now able to build metadata.

I have resolved most of the errors currently in the pipeline editor however I got stuck attempting to fix the error: error TS2322: Type '{ children: Element[]; theme: any; }' is not assignable to type 'IntrinsicAttributes & { theme: DeepPartial<Theme>; }'. Property 'children' does not exist on type 'IntrinsicAttributes & { theme: DeepPartial<Theme>; }'.

Updated CodeSnippetDisplay class to extend MetadataDisplay with the correct props type Replace usage of deprecated ContentFactory, but still exist issue when missing documentation.

tried to fix the first code cell creation error, but still have issue when inserting cell to notebook widget

Just figured out how to properly add codecell.

Fixed some method calling base on documentation.

- .value.text does not work for updating the content of Cell, Replaced with .setSource. - Refresh no longer exists, replaced with redo. Can't find any documentation about this change. - fixed creation of preview editor

Resolved final error in pipeline editor. Now it's able to build.

This reverts commit ac10f57.

…ork on Paulo's)

paulovmr · 2024-09-10T12:54:23Z

Merging this to the opendatahub-io/jupyterlab4 branch to continue the work there.

paulovmr force-pushed the jupyterlab4-upgrade branch from 59054d5 to 6ff5496 Compare August 21, 2024 20:35

lresende and others added 29 commits August 30, 2024 10:29

Update Elyra's version to 4.0.0

2d12f3e

Signed-off-by: Luciano Resende <[email protected]>

Update 3rd party extensions to Lab4 compatible

62fc44d

Signed-off-by: Luciano Resende <[email protected]>

Initial JupyterLab 4.0 support

cd0fa54

Signed-off-by: Luciano Resende <[email protected]>

Update build to use yarn 3.5

f9d1b70

Signed-off-by: Luciano Resende <[email protected]>

wip - code changes to lab4

fe735f1

Signed-off-by: Luciano Resende <[email protected]>

Fixed issues with yarn module and build errors.

cf0d20b

Updated LauncherModel to accommodate changes in @lumino/algorithm. Resolved build errors related to missing properties and import issues.

Fixing compile errors for ui-components

4b1b672

TypeScript Error: Incompatibility Component Structure: Clarification Prop Types: Consistency and Definition

python editor is not able to build

eeb2d14

Note: to compile python editor, build script editor first

Update CodeBlock.tsx

14a702b

Updated CodeBlock to uses updated version of CodeEditor. Changed the implementation base on the source code for IOptions: https://github.com/jupyterlab/jupyterlab/blob/d274f84/packages/codeeditor/src/editor.ts#L553

Update Tags.tsx

317f35a

fixed type errors for TagsField

FormRendererRegistry Changes

3bc08b2

Changed IFormComponentRegistry in metadata and meta-data common to use IFormRendererRegistry for 4.x.

Scala editor updated

755bc74

Updated Scala editor to be compatible with 4.x. The code used to use IConfig which is no longer in use. But config options is now currently under IOptions. But we need to see if It displays properly on frontend. But the code currently builds.

Refactored code snippet insertion for JupyterLab 4.x compatibility

aed7a99

Updated CodeSnippetDisplay class to extend MetadataDisplay with the correct props type Replace usage of deprecated ContentFactory, but still exist issue when missing documentation.

Attempt to fix cell creation

72ae16b

tried to fix the first code cell creation error, but still have issue when inserting cell to notebook widget

Update CodeSnippetWidget.tsx

d1372bf

Just figured out how to properly add codecell.

Update CodeSnippetWidget.tsx

2e4db92

Fixed some method calling base on documentation.

updated code snippet display functionality

6d10c67

- .value.text does not work for updating the content of Cell, Replaced with .setSource. - Refresh no longer exists, replaced with redo. Can't find any documentation about this change. - fixed creation of preview editor

PipelineEditorFixed

1135f1b

Resolved final error in pipeline editor. Now it's able to build.

updated naming for interface to match naming conventionn

d643a80

regex format match

1bbc4f3

Test remove unused

d592bf0

test

8fe4155

verifying elyra do build

c829e80

Revert "test"

f65cf19

This reverts commit ac10f57.

paulovmr and others added 28 commits August 30, 2024 15:01

Set yarn version for workflows

ba28d44

Fix build

83b5fae

Migrated script-debugger extension to JupyterLab 4

543113d

Migrated code-snippet extension to JupyterLab 4

2075ea1

Migrated metadata extension to JupyterLab 4

11ded3a

Migrated python-editor extension to JupyterLab 4

36aa9be

Remove function call no longer applicable

0530741

Bump action versions

e1dc4bc

Disable sourceMap to make Cypress run again

befea26

Migrated metadata-common and script-editor packages to JupyterLab 4

fe86116

Migrated services and ui-components packages to JupyterLab 4

783be08

Standardize package scripts

2aaa0c1

Include labextension outputs inside the distribution file

80937c7

Unblock metadata editor to be run

b6a263b

Provide artifacts on the CI

c0b383f

Add passWithNoTests flag

bbb5420

Add name to the test artifacts output file

c1bebeb

Fix New Python file not working

6407bd0

Fix Accept button not being found by e2e

38b5d91

Fix launcher not being present after test transition

efb4b98

Fix tab icon not being shown

ebdeafc

Improve CI artifact names

ed8e4d8

Fix context menu not being shown

3eec543

Fix ScriptEditor types

485dd0c

Upgraded jest libraries and configuration

58517a3

Migration from Jupyter 4.0.6 to 4.2.5 (not working on my local, but w…

9c60395

…ork on Paulo's)

Fixed loop in theme extension

77cb16a

Upgraded jupyterlab-lsp and jupyter-resource-usage

2bfac05

paulovmr merged commit 9cb2e21 into opendatahub-io:jupyterlab4 Sep 10, 2024
15 of 16 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] JupyterLab 4.x upgrade #25

[WIP] JupyterLab 4.x upgrade #25

paulovmr commented Aug 21, 2024

paulovmr commented Sep 10, 2024

[WIP] JupyterLab 4.x upgrade #25

[WIP] JupyterLab 4.x upgrade #25

Conversation

paulovmr commented Aug 21, 2024

What changes were proposed in this pull request?

How was this pull request tested?

paulovmr commented Sep 10, 2024