-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(control_validator): add hold and lpf #9120
base: main
Are you sure you want to change the base?
feat(control_validator): add hold and lpf #9120
Conversation
Signed-off-by: Yuki Takagi <[email protected]>
Signed-off-by: Yuki Takagi <[email protected]>
Signed-off-by: Yuki Takagi <[email protected]>
Signed-off-by: Yuki Takagi <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
@yuki-takagi-66 |
@yuki-takagi-66 Also, since I'm not familiar with the background of these changes, the processing seems fine to me. However, is it appropriate for me to approve without understanding the context or motivation behind these changes? |
Signed-off-by: Yuki Takagi <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9120 +/- ##
=======================================
Coverage 27.41% 27.41%
=======================================
Files 1302 1303 +1
Lines 95842 95894 +52
Branches 39128 39137 +9
=======================================
+ Hits 26274 26289 +15
- Misses 66912 66949 +37
Partials 2656 2656
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@kyoichi-sugahara I think we have no additional information to be added as docstrings from the function name and the arg names.
Maybe it is not a sufficient description, LPF and hold is required to achieve the appropriate behavior along with MRM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
This PR add holding function and LPF for the velocity check.
in additon, velocity check is separated to two diags to trigger different MRM behavior.
Related links
launch PR: autowarefoundation/autoware_launch#1193
Parent Issue:
How was this PR tested?
tier4 internal tests
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.